MarcoBuster/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-06-08 14:18:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add limitation for a project's column to 20

Browse Source
This commit is contained in:
Lunny Xiao 2024-04-30 15:21:38 +08:00
parent 81d455fa6c
commit 03562c7ff7
No known key found for this signature in database
GPG Key ID: C3B7C91B632F738A
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
models/project/board.go
View File

@ -150,22 +150,31 @@ func createBoardsForProjectsType(ctx context.Context, project *Project) error {
return db.Insert(ctx, boards)
}
// maxProjectColumns max columns allowed in a project, this should not bigger than 127
// because sorting is int8 in database
const maxProjectColumns = 20
// NewBoard adds a new project board to a given project
func NewBoard(ctx context.Context, board *Board) error {
if len(board.Color) != 0 && !BoardColorPattern.MatchString(board.Color) {
return fmt.Errorf("bad color code: %s", board.Color)
}
var maxSorting int8
if _, err := db.GetEngine(ctx).Select("Max(sorting)").Table("project_board").
Where("project_id=?", board.ProjectID).Get(&maxSorting); err != nil {
totalColumns, err := db.GetEngine(ctx).Table("project_board").
Where("project_id=?", board.ProjectID).Count()
if err != nil {
return err
}
if maxSorting > 0 {
board.Sorting = maxSorting + 1
if totalColumns >= maxProjectColumns {
return fmt.Errorf("NewBoard: maximum number of columns reached")
}
_, err := db.GetEngine(ctx).Insert(board)
if totalColumns > 0 {
board.Sorting = int8(totalColumns)
}
_, err = db.GetEngine(ctx).Insert(board)
return err
}

2
models/project/issue.go
View File

@ -130,7 +130,7 @@ func MoveColumnsOnProject(ctx context.Context, project *Project, sortedColumnIDs
for _, column := range movedColumns {
if column.ProjectID != project.ID {
return errors.New("Some column's projectID is not equal to project's ID")
return errors.New("some column's projectID is not equal to project's ID")
}
}