From 956724fbc1bf7bff1f01a7b283075de44bf2dd47 Mon Sep 17 00:00:00 2001 From: Chris Vest Date: Wed, 1 Sep 2021 11:20:24 +0200 Subject: [PATCH] Remove test that no longer makes sense because it relied on being able to change buffer byte order --- .../ByteToMessageDecoderTest.java | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/buffer-tests/src/test/java/io/netty/buffer/api/tests/examples/bytetomessagedecoder/ByteToMessageDecoderTest.java b/buffer-tests/src/test/java/io/netty/buffer/api/tests/examples/bytetomessagedecoder/ByteToMessageDecoderTest.java index 2c3e7f3..d4a79c3 100644 --- a/buffer-tests/src/test/java/io/netty/buffer/api/tests/examples/bytetomessagedecoder/ByteToMessageDecoderTest.java +++ b/buffer-tests/src/test/java/io/netty/buffer/api/tests/examples/bytetomessagedecoder/ByteToMessageDecoderTest.java @@ -447,18 +447,6 @@ public class ByteToMessageDecoderTest { } } - @Test - public void releaseWhenCompositeCumulateThrows() { - Buffer in = onHeapUnpooled().allocate(12).writerOffset(12); - try (Buffer cumulation = compose(onHeapUnpooled(), onHeapUnpooled().allocate(1).writeByte((byte) 0).send())) { - ByteToMessageDecoder.COMPOSITE_CUMULATOR.cumulate(onHeapUnpooled(), cumulation, in); - fail(); - } catch (IllegalArgumentException expected) { - assertThat(expected).hasMessageContaining("byte order"); - assertFalse(in.isAccessible()); - } - } - @Test public void testDoesNotOverRead() { class ReadInterceptingHandler implements ChannelHandler {