andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dri2: return FALSE not BadValue.

Browse Source 
With 1.7 if you try and send a DRI2Connect with this value set
to anything but 0, the server will segfault due to the strlen
in the function this returns to, since BadValue != FALSE.

Fixed via other work in 1.8.

Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Dave Airlie 2010-03-10 16:07:09 +10:00
parent 1242e494c8
commit 3ae6a3779d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/xfree86/dri2/dri2.c
View File

@ -387,7 +387,7 @@ DRI2Connect(ScreenPtr pScreen, unsigned int driverType, int *fd,
return FALSE;
if (driverType != DRI2DriverDRI)
return BadValue;
return FALSE;
*fd = ds->fd;
*driverName = ds->driverName;