From 9c72887939f319e185d2726d9d9a4191b9d12efd Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Mon, 20 Nov 2017 15:43:05 -0500 Subject: [PATCH] os: Make OsSignalHandler ask for core dumps for signo != SIGQUIT SIGQUIT is a normal termination request, but any other signal we handle here wants a core. This has the effect of making FatalError's call to AbortServer trigger the if (CoreDump) OsAbort(); path. This will allow us to remove some DDX code that has the same net effect. Signed-off-by: Adam Jackson Reviewed-by: Olivier Fourdan Reviewed-by: Dave Airlie --- os/osinit.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/os/osinit.c b/os/osinit.c index cd769d181..8575319ff 100644 --- a/os/osinit.c +++ b/os/osinit.c @@ -52,6 +52,7 @@ SOFTWARE. #include #include "os.h" #include "osdep.h" +#include "opaque.h" #include #include #include @@ -74,8 +75,6 @@ SOFTWARE. #define ADMPATH "/usr/adm/X%smsgs" #endif -extern char *display; - #ifdef RLIMIT_DATA int limitDataSpace = -1; #endif @@ -151,6 +150,9 @@ OsSigHandler(int signo) } #endif + if (signo != SIGQUIT) + CoreDump = TRUE; + FatalError("Caught signal %d (%s). Server aborting\n", signo, strsignal(signo)); }