xkb: don't assign garbage value to led_return.
As the comment for the function states, led_return is undefined if map is
NULL. We might as well skip writing to it then.
Found by clang.
Reported-by: Tomas Carnecky <tom@dbservice.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
(cherry picked from commit 12fb31815d
)
This commit is contained in:
parent
0f71be87b9
commit
c18dd3fd9b
|
@ -3273,20 +3273,21 @@ _XkbFindNamedIndicatorMap(XkbSrvLedInfoPtr sli, Atom indicator,
|
|||
int *led_return)
|
||||
{
|
||||
XkbIndicatorMapPtr map;
|
||||
int led;
|
||||
|
||||
/* search for the right indicator */
|
||||
map = NULL;
|
||||
if (sli->names && sli->maps) {
|
||||
int led;
|
||||
|
||||
for (led = 0; (led < XkbNumIndicators) && (map == NULL); led++) {
|
||||
if (sli->names[led] == indicator) {
|
||||
map= &sli->maps[led];
|
||||
*led_return = led;
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
*led_return = led;
|
||||
return map;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue