MarcoBuster/Gadgetbridge
1
0
Fork 0
mirror of https://codeberg.org/Freeyourgadget/Gadgetbridge synced 2024-11-15 06:29:24 +01:00
Code Releases Wiki Activity
cbe73f71a1
Gadgetbridge/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/activities/AlarmDetails.java

87 lines
3.2 KiB
Java
Raw Normal View History

Initial implementation of setting alarms to the Mi Band. The code basically works, but there a lot of things to fix / improve. * The alarms are stored to and read from the Shared Preferences, but there is no persistence within the app (basically they are read and stored at every access) * The alarm list is not updated when coming back from the alarm detail view (probably related to the point above), but the actual alarm is * The alarms preference names is sometimes built by concatenating strings, which is not really safe * There is no check in the alarm constructor whether the stored string is a valid alarm representation * Even though only 3 alarms can be stored on the device, we could have more in the app and let the user choose which to sync * In the alarm detail view XML some material* drawables are used, it's possible that these break on android version < 5 * ...
2015-06-24 20:14:08 +02:00
package nodomain.freeyourgadget.gadgetbridge.activities;
import android.app.Activity;
import android.os.Bundle;
use parcelable for passing alarms around
2015-06-25 14:34:21 +02:00
import android.os.Parcelable;
Initial implementation of setting alarms to the Mi Band. The code basically works, but there a lot of things to fix / improve. * The alarms are stored to and read from the Shared Preferences, but there is no persistence within the app (basically they are read and stored at every access) * The alarm list is not updated when coming back from the alarm detail view (probably related to the point above), but the actual alarm is * The alarms preference names is sometimes built by concatenating strings, which is not really safe * There is no check in the alarm constructor whether the stored string is a valid alarm representation * Even though only 3 alarms can be stored on the device, we could have more in the app and let the user choose which to sync * In the alarm detail view XML some material* drawables are used, it's possible that these break on android version < 5 * ...
2015-06-24 20:14:08 +02:00
import android.text.format.DateFormat;
further improvements: - the day of week are evenly spread across the screen in the alarms detail activity - the alarms are stored in a single shared preference (as a set) NB: you'll have to reset your alarms if you used a previous version (and also manually clean the shared preferences, but this is not needed) - the list of alarms gets correctly updated after editing a specific alarm - the actionbar back button saves the alarm status, the device back button doesn't. I'm not sure if it's a bug or a feature :)
2015-06-26 17:22:42 +02:00
import android.view.MenuItem;
Get rid of the Checkedtextview because they weren't in line with the our style
2015-06-27 18:32:13 +02:00
import android.widget.CheckBox;
Initial implementation of setting alarms to the Mi Band. The code basically works, but there a lot of things to fix / improve. * The alarms are stored to and read from the Shared Preferences, but there is no persistence within the app (basically they are read and stored at every access) * The alarm list is not updated when coming back from the alarm detail view (probably related to the point above), but the actual alarm is * The alarms preference names is sometimes built by concatenating strings, which is not really safe * There is no check in the alarm constructor whether the stored string is a valid alarm representation * Even though only 3 alarms can be stored on the device, we could have more in the app and let the user choose which to sync * In the alarm detail view XML some material* drawables are used, it's possible that these break on android version < 5 * ...
2015-06-24 20:14:08 +02:00
import android.widget.TimePicker;
import nodomain.freeyourgadget.gadgetbridge.GBApplication;
import nodomain.freeyourgadget.gadgetbridge.R;
Refactoring The notfification APIs now use NotificationSpec as their only parameter, which contains all information (required and optional ones). We no longer have separate methods and actions for SMS/EMAIL/GENERIC anymore. The type of notification is important now, not how we received them technically.
2015-09-24 14:45:21 +02:00
import nodomain.freeyourgadget.gadgetbridge.impl.GBAlarm;
Initial implementation of setting alarms to the Mi Band. The code basically works, but there a lot of things to fix / improve. * The alarms are stored to and read from the Shared Preferences, but there is no persistence within the app (basically they are read and stored at every access) * The alarm list is not updated when coming back from the alarm detail view (probably related to the point above), but the actual alarm is * The alarms preference names is sometimes built by concatenating strings, which is not really safe * There is no check in the alarm constructor whether the stored string is a valid alarm representation * Even though only 3 alarms can be stored on the device, we could have more in the app and let the user choose which to sync * In the alarm detail view XML some material* drawables are used, it's possible that these break on android version < 5 * ...
2015-06-24 20:14:08 +02:00
public class AlarmDetails extends Activity {
private GBAlarm alarm;
private TimePicker timePicker;
Get rid of the Checkedtextview because they weren't in line with the our style
2015-06-27 18:32:13 +02:00
private CheckBox cbSmartWakeup;
private CheckBox cbMonday;
private CheckBox cbTuesday;
private CheckBox cbWednesday;
private CheckBox cbThursday;
private CheckBox cbFriday;
private CheckBox cbSaturday;
private CheckBox cbSunday;
Initial implementation of setting alarms to the Mi Band. The code basically works, but there a lot of things to fix / improve. * The alarms are stored to and read from the Shared Preferences, but there is no persistence within the app (basically they are read and stored at every access) * The alarm list is not updated when coming back from the alarm detail view (probably related to the point above), but the actual alarm is * The alarms preference names is sometimes built by concatenating strings, which is not really safe * There is no check in the alarm constructor whether the stored string is a valid alarm representation * Even though only 3 alarms can be stored on the device, we could have more in the app and let the user choose which to sync * In the alarm detail view XML some material* drawables are used, it's possible that these break on android version < 5 * ...
2015-06-24 20:14:08 +02:00
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_alarm_details);
use parcelable for passing alarms around
2015-06-25 14:34:21 +02:00
Parcelable p = getIntent().getExtras().getParcelable("alarm");
alarm = (GBAlarm) p;
timePicker = (TimePicker) findViewById(R.id.alarm_time_picker);
Get rid of the Checkedtextview because they weren't in line with the our style
2015-06-27 18:32:13 +02:00
cbSmartWakeup = (CheckBox) findViewById(R.id.alarm_cb_smart_wakeup);
cbMonday = (CheckBox) findViewById(R.id.alarm_cb_mon);
cbTuesday = (CheckBox) findViewById(R.id.alarm_cb_tue);
cbWednesday = (CheckBox) findViewById(R.id.alarm_cb_wed);
cbThursday = (CheckBox) findViewById(R.id.alarm_cb_thu);
cbFriday = (CheckBox) findViewById(R.id.alarm_cb_fri);
cbSaturday = (CheckBox) findViewById(R.id.alarm_cb_sat);
cbSunday = (CheckBox) findViewById(R.id.alarm_cb_sun);
use parcelable for passing alarms around
2015-06-25 14:34:21 +02:00
timePicker.setIs24HourView(DateFormat.is24HourFormat(GBApplication.getContext()));
timePicker.setCurrentHour(alarm.getHour());
timePicker.setCurrentMinute(alarm.getMinute());
Get rid of the Checkedtextview because they weren't in line with the our style
2015-06-27 18:32:13 +02:00
cbSmartWakeup.setChecked(alarm.isSmartWakeup());
use parcelable for passing alarms around
2015-06-25 14:34:21 +02:00
Get rid of the Checkedtextview because they weren't in line with the our style
2015-06-27 18:32:13 +02:00
cbMonday.setChecked(alarm.getRepetition(GBAlarm.ALARM_MON));
cbTuesday.setChecked(alarm.getRepetition(GBAlarm.ALARM_TUE));
cbWednesday.setChecked(alarm.getRepetition(GBAlarm.ALARM_WED));
cbThursday.setChecked(alarm.getRepetition(GBAlarm.ALARM_THU));
cbFriday.setChecked(alarm.getRepetition(GBAlarm.ALARM_FRI));
cbSaturday.setChecked(alarm.getRepetition(GBAlarm.ALARM_SAT));
cbSunday.setChecked(alarm.getRepetition(GBAlarm.ALARM_SUN));
Initial implementation of setting alarms to the Mi Band. The code basically works, but there a lot of things to fix / improve. * The alarms are stored to and read from the Shared Preferences, but there is no persistence within the app (basically they are read and stored at every access) * The alarm list is not updated when coming back from the alarm detail view (probably related to the point above), but the actual alarm is * The alarms preference names is sometimes built by concatenating strings, which is not really safe * There is no check in the alarm constructor whether the stored string is a valid alarm representation * Even though only 3 alarms can be stored on the device, we could have more in the app and let the user choose which to sync * In the alarm detail view XML some material* drawables are used, it's possible that these break on android version < 5 * ...
2015-06-24 20:14:08 +02:00
}
@Override
further improvements: - the day of week are evenly spread across the screen in the alarms detail activity - the alarms are stored in a single shared preference (as a set) NB: you'll have to reset your alarms if you used a previous version (and also manually clean the shared preferences, but this is not needed) - the list of alarms gets correctly updated after editing a specific alarm - the actionbar back button saves the alarm status, the device back button doesn't. I'm not sure if it's a bug or a feature :)
2015-06-26 17:22:42 +02:00
public boolean onOptionsItemSelected(MenuItem item) {
switch (item.getItemId()) {
case android.R.id.home:
// back button
finish();
return true;
}
return super.onOptionsItemSelected(item);
}
private void updateAlarm() {
Get rid of the Checkedtextview because they weren't in line with the our style
2015-06-27 18:32:13 +02:00
alarm.setSmartWakeup(cbSmartWakeup.isChecked());
alarm.setRepetition(cbMonday.isChecked(), cbTuesday.isChecked(), cbWednesday.isChecked(), cbThursday.isChecked(), cbFriday.isChecked(), cbSaturday.isChecked(), cbSunday.isChecked());
Initial implementation of setting alarms to the Mi Band. The code basically works, but there a lot of things to fix / improve. * The alarms are stored to and read from the Shared Preferences, but there is no persistence within the app (basically they are read and stored at every access) * The alarm list is not updated when coming back from the alarm detail view (probably related to the point above), but the actual alarm is * The alarms preference names is sometimes built by concatenating strings, which is not really safe * There is no check in the alarm constructor whether the stored string is a valid alarm representation * Even though only 3 alarms can be stored on the device, we could have more in the app and let the user choose which to sync * In the alarm detail view XML some material* drawables are used, it's possible that these break on android version < 5 * ...
2015-06-24 20:14:08 +02:00
alarm.setHour(timePicker.getCurrentHour());
alarm.setMinute(timePicker.getCurrentMinute());
further improvements: - the day of week are evenly spread across the screen in the alarms detail activity - the alarms are stored in a single shared preference (as a set) NB: you'll have to reset your alarms if you used a previous version (and also manually clean the shared preferences, but this is not needed) - the list of alarms gets correctly updated after editing a specific alarm - the actionbar back button saves the alarm status, the device back button doesn't. I'm not sure if it's a bug or a feature :)
2015-06-26 17:22:42 +02:00
alarm.store();
Initial implementation of setting alarms to the Mi Band. The code basically works, but there a lot of things to fix / improve. * The alarms are stored to and read from the Shared Preferences, but there is no persistence within the app (basically they are read and stored at every access) * The alarm list is not updated when coming back from the alarm detail view (probably related to the point above), but the actual alarm is * The alarms preference names is sometimes built by concatenating strings, which is not really safe * There is no check in the alarm constructor whether the stored string is a valid alarm representation * Even though only 3 alarms can be stored on the device, we could have more in the app and let the user choose which to sync * In the alarm detail view XML some material* drawables are used, it's possible that these break on android version < 5 * ...
2015-06-24 20:14:08 +02:00
}
Improvements to how and when alarms are sent to the device They are now sent whenever the Alarms activity is finished. Display "All alarms disabled" when no alarm is enabled. Unrelated: pass exceptions to GB.toast() where applicable.
2015-10-18 23:52:59 +02:00
@Override
protected void onPause() {
updateAlarm();
super.onPause();
}
Initial implementation of setting alarms to the Mi Band. The code basically works, but there a lot of things to fix / improve. * The alarms are stored to and read from the Shared Preferences, but there is no persistence within the app (basically they are read and stored at every access) * The alarm list is not updated when coming back from the alarm detail view (probably related to the point above), but the actual alarm is * The alarms preference names is sometimes built by concatenating strings, which is not really safe * There is no check in the alarm constructor whether the stored string is a valid alarm representation * Even though only 3 alarms can be stored on the device, we could have more in the app and let the user choose which to sync * In the alarm detail view XML some material* drawables are used, it's possible that these break on android version < 5 * ...
2015-06-24 20:14:08 +02:00
}
Copy Permalink