From 12b3ff34e269e5e34a387d3ccbfa8858c18fbf26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Rebelo?= Date: Tue, 11 Jun 2024 20:50:06 +0100 Subject: [PATCH] Garmin: Send all notification types as foreground Sending notifications for some apps is unexpected for most users, which was generating some bug reports. For now, send all notifications as foreground, at least until we can make what is happening more clear or configurable. --- .../devices/garmin/messages/NotificationUpdateMessage.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/garmin/messages/NotificationUpdateMessage.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/garmin/messages/NotificationUpdateMessage.java index fa286b7ef..e32268f2f 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/garmin/messages/NotificationUpdateMessage.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/garmin/messages/NotificationUpdateMessage.java @@ -104,7 +104,9 @@ public class NotificationUpdateMessage extends GFDIMessage { case "generic_social": case "generic_alarm_clock": case "generic": - flags.add(NotificationFlag.BACKGROUND); + // TODO: Maybe make this configurable, but most users expect all notifications + // to be foreground, sending them as background was generating bug reports. + flags.add(NotificationFlag.FOREGROUND); } return (int) EnumUtils.generateBitVector(NotificationFlag.class, flags); }