From 396aa4164701f268ade9d3b74857bbcb20d4e64a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Sun, 15 Dec 2024 12:28:57 +0200 Subject: [PATCH] Xiaomi: Add a comment about possible interpretation of unknown bytes in v5 freestyle activity parser They're probably the same as for v8. --- .../devices/xiaomi/activity/impl/WorkoutSummaryParser.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/activity/impl/WorkoutSummaryParser.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/activity/impl/WorkoutSummaryParser.java index 866b75c8b..77f2be8b2 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/activity/impl/WorkoutSummaryParser.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/activity/impl/WorkoutSummaryParser.java @@ -274,7 +274,7 @@ public class WorkoutSummaryParser extends XiaomiActivityParser implements Activi builder.addByte(HR_MAX, UNIT_BPM); builder.addByte(HR_MIN, UNIT_BPM); if (version == 5) { - builder.addUnknown(7); + builder.addUnknown(7); // probably training effect aerobic and recovery time? } else { builder.addUnknown(6); builder.addFloat(TRAINING_EFFECT_AEROBIC, UNIT_NONE); @@ -288,7 +288,7 @@ public class WorkoutSummaryParser extends XiaomiActivityParser implements Activi builder.addInt(HR_ZONE_FAT_BURN, UNIT_SECONDS); builder.addInt(HR_ZONE_WARM_UP, UNIT_SECONDS); if (version == 5) { - builder.addUnknown(10); + builder.addUnknown(10); // Probably the same as for v8 below? builder.addShort(XIAOMI_WORKOUT_TYPE, XIAOMI_WORKOUT_TYPE); builder.addUnknown(2); builder.addInt("configuredTimeGoal", UNIT_SECONDS);