From 3ad1412a1d5fd650e164772bcdde61d0fb0d3abc Mon Sep 17 00:00:00 2001 From: TaaviE Date: Tue, 28 Jul 2020 04:03:34 +0300 Subject: [PATCH] Delegated error handling properly to the function that creates FetchActivityOperation --- .../devices/miband/operations/FetchActivityOperation.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/miband/operations/FetchActivityOperation.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/miband/operations/FetchActivityOperation.java index b526ec314..082fbfa8a 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/miband/operations/FetchActivityOperation.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/miband/operations/FetchActivityOperation.java @@ -151,15 +151,13 @@ public class FetchActivityOperation extends AbstractMiBand1Operation { private ActivityStruct activityStruct; - public FetchActivityOperation(MiBandSupport support) { + public FetchActivityOperation(MiBandSupport support) throws IOException { super(support); if (support == null) { - LOG.error("MiBandSupport was null"); - return; + throw new IOException("MiBandSupport was null"); } if (support.getDeviceInfo() == null) { - LOG.error("MiBandSupport getDeviceInfo returned null"); - return; + throw new IOException("MiBandSupport getDeviceInfo returned null"); } hasExtendedActivityData = support.getDeviceInfo().supportsHeartrate(); hasPacketCounter = support.getDeviceInfo().getProfileVersion() >= 0x02000700;