MarcoBuster/Gadgetbridge
1
0
Fork 0
mirror of https://codeberg.org/Freeyourgadget/Gadgetbridge synced 2025-01-24 08:37:32 +01:00
Code Releases Wiki Activity

Detect IllegalStateException from Context.startService and log an error rather than crashing (this is the cause of ~80% of Play Store crashes right now)

Browse Source
This commit is contained in:
Gordon Williams 2022-10-14 09:56:08 +01:00
parent eac7edfea1
commit 44ee39a4de
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/impl/GBDeviceService.java
View File

@ -47,10 +47,14 @@ import nodomain.freeyourgadget.gadgetbridge.model.Reminder;
import nodomain.freeyourgadget.gadgetbridge.model.WeatherSpec;
import nodomain.freeyourgadget.gadgetbridge.model.WorldClock;
import nodomain.freeyourgadget.gadgetbridge.service.DeviceCommunicationService;
import nodomain.freeyourgadget.gadgetbridge.service.devices.banglejs.BangleJSDeviceSupport;
import nodomain.freeyourgadget.gadgetbridge.util.RtlUtils;
import static nodomain.freeyourgadget.gadgetbridge.util.JavaExtensions.coalesce;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class GBDeviceService implements DeviceService {
protected final Context mContext;
@ -69,6 +73,7 @@ public class GBDeviceService implements DeviceService {
EXTRA_CALENDAREVENT_TITLE,
EXTRA_CALENDAREVENT_DESCRIPTION
};
private static final Logger LOG = LoggerFactory.getLogger(GBDeviceService.class);
public GBDeviceService(Context context) {
this(context, null);
@ -106,8 +111,11 @@ public class GBDeviceService implements DeviceService {
if (mDevice != null) {
intent.putExtra(GBDevice.EXTRA_DEVICE, mDevice);
}
mContext.startService(intent);
try {
mContext.startService(intent);
} catch (IllegalStateException e) {
LOG.error("IllegalStateException during startService ("+intent.getAction()+")");
}
}
protected void stopService(Intent intent) {