From 5dd746f2d6477c6815b8d9d3e209eb6ac4a43359 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Rebelo?= Date: Wed, 18 Oct 2023 17:01:42 +0100 Subject: [PATCH] Xiaomi: Ack activity before parsing for now --- .../xiaomi/activity/XiaomiActivityFileFetcher.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/activity/XiaomiActivityFileFetcher.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/activity/XiaomiActivityFileFetcher.java index 1726450f0..b41c7864d 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/activity/XiaomiActivityFileFetcher.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/activity/XiaomiActivityFileFetcher.java @@ -109,6 +109,12 @@ public class XiaomiActivityFileFetcher { dumpBytesToExternalStorage(fileId, data); } + if (!XiaomiPreferences.keepActivityDataOnDevice(mHealthService.getSupport().getDevice())) { + LOG.debug("Acking recorded data {}", fileId); + // TODO is this too early? + mHealthService.ackRecordedData(fileId); + } + final XiaomiActivityParser activityParser = XiaomiActivityParser.create(fileId); if (activityParser == null) { LOG.warn("Failed to find activity parser for {}", fileId); @@ -116,11 +122,8 @@ public class XiaomiActivityFileFetcher { return; } - if (activityParser.parse(mHealthService.getSupport(), fileId, activityData)) { - if (!XiaomiPreferences.keepActivityDataOnDevice(mHealthService.getSupport().getDevice())) { - LOG.debug("Acking recorded data {}", fileId); - mHealthService.ackRecordedData(fileId); - } + if (!activityParser.parse(mHealthService.getSupport(), fileId, activityData)) { + LOG.warn("Failed to parse {}", fileId); } triggerNextFetch();