From 8dee55198ea49d5589b3bebf967d281b4dbcb4e4 Mon Sep 17 00:00:00 2001 From: cpfeiffer Date: Thu, 6 Aug 2015 00:40:49 +0200 Subject: [PATCH] Don't (always) leak the file descriptor. It's still very much possible to leak the descriptor (when an exception occurs somewhere in between or anything else goes wrong). So maybe the whole thing should be redesigned to be independent of files. --- .../gadgetbridge/service/devices/pebble/PebbleIoThread.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/pebble/PebbleIoThread.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/pebble/PebbleIoThread.java index 0f50e69f4..ff920162f 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/pebble/PebbleIoThread.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/pebble/PebbleIoThread.java @@ -419,6 +419,11 @@ public class PebbleIoThread extends GBDeviceIoThread { mPBWReader = null; mIsInstalling = false; + try { + mZis.close(); + } catch (IOException e) { + // ignore + } mZis = null; mAppInstallToken = -1; mInstallSlot = -2;