From 8e010bc6ddaf4dbc7755411537b6b3038eed5064 Mon Sep 17 00:00:00 2001 From: Gordon Williams Date: Mon, 26 Jun 2023 11:15:54 +0100 Subject: [PATCH] Stop BangleJSDeviceSupport repeatedly calling GBLocationManager.stop and spamming the log with "Stop location updates" --- .../service/devices/banglejs/BangleJSDeviceSupport.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/banglejs/BangleJSDeviceSupport.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/banglejs/BangleJSDeviceSupport.java index ff2764b0c..bc86608a0 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/banglejs/BangleJSDeviceSupport.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/banglejs/BangleJSDeviceSupport.java @@ -155,7 +155,7 @@ public class BangleJSDeviceSupport extends AbstractBTLEDeviceSupport { private final LimitedQueue/*Long*/ mNotificationReplyAction = new LimitedQueue(16); - private Boolean gpsUpdateSetup = false; + private boolean gpsUpdateSetup = false; private Timer gpsPositionTimer; private final int gpsUpdateTimerInterval = 1000; @@ -200,6 +200,8 @@ public class BangleJSDeviceSupport extends AbstractBTLEDeviceSupport { private void stopLocationUpdate() { + if (!gpsUpdateSetup) + return; LOG.info("Stop location updates"); GBLocationManager.stop(getContext(), this); gpsUpdateSetup = false; @@ -968,6 +970,7 @@ public class BangleJSDeviceSupport extends AbstractBTLEDeviceSupport { } else { GB.toast("Phone gps data update is deactivated in the settings", Toast.LENGTH_SHORT, GB.INFO); } + gpsUpdateSetup = true; } @Override