MarcoBuster/Gadgetbridge
1
0
Fork 0
mirror of https://codeberg.org/Freeyourgadget/Gadgetbridge synced 2024-12-18 14:47:46 +01:00
Code Releases Wiki Activity

Huami: Prevent setting an MTU of < 23, which is either a special value or a parsing error of Gadgetbridge

Browse Source 
This fixes a problem where writeToChunked algorithm results in out of bounds writes or an endless loop.

Closes #1936
This commit is contained in:
Andreas Shimokawa 2020-08-02 13:11:41 +02:00
parent f9dc625c5c
commit a619fdb168
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/huami/HuamiSupport.java
View File

@ -1279,6 +1279,10 @@ public class HuamiSupport extends AbstractBTLEDeviceSupport {
if (!prefs.getBoolean(PREF_ALLOW_HIGH_MTU, false)) { if (!prefs.getBoolean(PREF_ALLOW_HIGH_MTU, false)) {
break; break;
} }
if (mtu < 23) {
LOG.error("Device announced unreasonable low MTU of " + mtu + ", ignoring");
break;
}
mMTU = mtu; mMTU = mtu;
/* /*
* not really sure if this would make sense, is this event already a proof of a successful MTU * not really sure if this would make sense, is this event already a proof of a successful MTU