From f2d935bfc1e9dc9c15d0b10581db4004d7f7a9c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Rebelo?= Date: Sun, 30 Jun 2024 09:11:45 +0100 Subject: [PATCH] Xiaomi Spp: Fix logging of unhandled packets --- .../service/devices/xiaomi/XiaomiSppSupport.java | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/XiaomiSppSupport.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/XiaomiSppSupport.java index f30b4473d..79c09725b 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/XiaomiSppSupport.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/xiaomi/XiaomiSppSupport.java @@ -272,15 +272,12 @@ public class XiaomiSppSupport extends XiaomiConnectionSupport { payload = mXiaomiSupport.getAuthService().decrypt(payload); } - int channel = packet.getChannel(); - if (mChannelHandlers.containsKey(channel)) { - XiaomiChannelHandler handler = mChannelHandlers.get(channel); - - if (handler != null) - handler.handle(payload); + final XiaomiChannelHandler handler = mChannelHandlers.get(packet.getChannel()); + if (handler != null) { + handler.handle(payload); + } else { + LOG.warn("Unhandled SppPacket on channel {}", packet.getChannel()); } - - LOG.warn("Unhandled SppPacket on channel {}", packet.getChannel()); } @Override