MarcoBuster/Gadgetbridge
1
0
Fork 0
mirror of https://codeberg.org/Freeyourgadget/Gadgetbridge synced 2024-12-25 18:15:49 +01:00
Code Releases Wiki Activity

Garmin: only add the cache-control header when updating the AGPS file

Browse Source 
Prevents it being stale for too long if the user forgets to fetch an updated file.
If the file has to be updated on the watch the response (http status 200) is sent and cached for 14400 seconds, for this period the watch will not request the file again.
Subsequent requests (http status 304) are very small and should not impact battery life negatively, hence they are sent without adding caching directives.
This commit is contained in:
Daniele Gobbetti 2024-06-08 16:29:52 +02:00
parent 09ca34fedf
commit fc8b959fea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/garmin/agps/AgpsHandler.java
View File

@ -50,7 +50,6 @@ public class AgpsHandler {
}
final GarminHttpResponse response = new GarminHttpResponse();
response.getHeaders().put("cache-control", "max-age=14400");
final byte[] rawBytes = FileUtils.readAll(agpsIn, 1024 * 1024); // 1MB, they're usually ~60KB
final String fileHash = GB.hexdump(CheckSums.md5(rawBytes)).toLowerCase(Locale.ROOT);
@ -68,6 +67,7 @@ public class AgpsHandler {
return response;
}
}
response.getHeaders().put("cache-control", "max-age=14400");
// Run some sanity checks on known agps file formats
final GarminAgpsFile garminAgpsFile = new GarminAgpsFile(rawBytes);