MarcoBuster/Gadgetbridge
1
0
Fork 0
mirror of https://codeberg.org/Freeyourgadget/Gadgetbridge synced 2024-07-26 00:23:25 +02:00
Code Releases Wiki Activity
4,905 Commits 74 Branches 230 Tags 64 MiB
7c15ddb471
Commit Graph

1534 Commits

Author SHA1 Message Date
Andreas Shimokawa
074994d24b Merge branch 'master' into fossil-q-hybrid 2019-10-12 20:47:19 +02:00
Andreas Shimokawa
4bf37ea70f Mi Band 4/Amazfit Bip Lite: Display a toast and do not try to pair if there was no auth key supplied 2019-10-12 19:44:45 +02:00
Andreas Shimokawa
8fefd1b49e * Mi Band 4/Amazfit Bip Lite: Trim white spaces and new lines from auth key 2019-10-12 19:04:12 +02:00
Cre3per
c4f4f5081d added vibrator to FindPhoneActivity. 
added device settings for find phone.
makibes hr3 now uses GBDeviceEventFindPhone.
 2019-10-12 12:44:38 +02:00
Cre3per
4437220c54 makibes hr3. 
added quite hours.
 2019-10-12 12:44:38 +02:00
Cre3per
5570ac8349 makibes hr3. 
added fakeBattery.
fixed string comparison using operator.
 2019-10-12 12:44:38 +02:00
Cre3per
1262970494 makibes hr3. 
added lost reminder support.
 2019-10-12 12:44:38 +02:00
Cre3per
4c98d8537f makibes hr3. 
added hud to device settings.
 2019-10-12 12:44:38 +02:00
Cre3per
ec88a7d8e5 makibes hr3. 
fixed step counting (needs multi-day testing).
fixed signed byte to int conversion.
 2019-10-12 12:44:38 +02:00
Cre3per
fdffe813f2 makibes hr3. 
download progress notification (needs to be tested).
 2019-10-12 12:44:38 +02:00
Cre3per
cd3558cd50 makibes hr3. 
fixed long notifications a a nullptrexception.
added vibration timeout.
added step history download.
 2019-10-12 12:44:38 +02:00
Cre3per
da1a72c6c6 makibes hr3. 
implemented deleteDevice.
implemented heart rate history download.
cleaned up sample handling.
 2019-10-12 12:44:38 +02:00
Cre3per
40696cb3e6 makibes hr3. 
added multi-byte command support.
now uploading personal data to the watch.
 2019-10-12 12:44:38 +02:00
Cre3per
5e581f781a added todos 2019-10-12 12:44:38 +02:00
Cre3per
fe667ffdd8 added makibes hr3 todo and heart rate constants 2019-10-12 12:44:38 +02:00
Cre3per
0a7639877b fixed alarm repetition 2019-10-12 12:44:38 +02:00
Cre3per
81aa66c2d4 removed todo. 
fixed typo.
 2019-10-12 12:44:38 +02:00
Cre3per
8b7d853097 merged. 
added makibes hr3 OnSharedPreferenceChangeListener.
added makibes hr3 reverse find device (find phone).
added makibes hr3 heart rate/steps/firmware version.
 2019-10-12 12:44:38 +02:00
dakhnod
a2a0bc08dd Merge branch 'master' of github.com:Freeyourgadget/Gadgetbridge into fossil-q-hybrid 2019-10-11 22:35:50 +02:00
Daniel Dakhno
28ff99f534 adjusted to use custom icon 2019-10-11 03:49:59 +02:00
Andreas Shimokawa
8d27ad1996 another try at bip lite support 2019-10-09 21:33:55 +02:00
Andreas Shimokawa
b5e9727dcd Make some more settings per-device settings 
- All ID115 settings migrated, allowing removal from settings activity
- All timeformat settings for all devices migrated
- All wrist location settings for all devices migrated (now you can have a mi band 3 on the left wrist and a bip  on the right wrist :P)

Also deduplicated some strings from zetime/generic preferences
 2019-10-05 22:35:30 +02:00
dakhnod
ea1653d616 Merge branch 'master' of github.com:Freeyourgadget/Gadgetbridge into fossil-q-hybrid 2019-10-05 19:09:07 +02:00
MyTimeKill
a0e3e060cc
Amazfit Bip: Whitelist fw 1.1.6.30 latin, res and latin ft 2019-10-03 22:18:01 +09:00
Andreas Shimokawa
21a287f6b1 Makibes HR3: Make settings per-device 
Also so some minor cleanups on Makibes HR3 code
 2019-10-02 23:45:19 +02:00
Cre3per
7409281c5a very basic makibes hr3 support 2019-10-02 23:06:33 +02:00
MyTimeKill
8df99bf5bd
Amazfit bip: Support flashing latest latin font 2019-10-02 18:00:34 +09:00
dakhnod
73a698d5db formatting 2019-10-01 21:57:01 +02:00
dakhnod
8be08d8c2c added battery characteristic notification 2019-10-01 21:53:41 +02:00
Daniel Dakhno
ebab69a063 added firmware check on connect 2019-10-01 16:05:47 +02:00
dakhnod
b20963348d Merge branch 'master' of github.com:Freeyourgadget/Gadgetbridge into fossil-q-hybrid 2019-09-25 00:22:57 +02:00
dakhnod
5ce5b5d8a4 replaced BatteryLevelRequest with native characteristic 2019-09-25 00:21:16 +02:00
cpfeiffer
17f24c06f8 Fix some LGTM issues 2019-09-19 23:18:17 +02:00
Andreas Shimokawa
8374a2b8f8 Widget: also try to signal sleep/steps updates for pebble 2019-09-16 23:18:12 +02:00
Andreas Shimokawa
fcc9ad8f95 Widget: Also update for Pebble Misfit and Morpheuz 
This commit also removes GBDeviceEventSleepMonitorResult since it was unused and highly Morpheuz specific
 2019-09-16 22:48:21 +02:00
Andreas Shimokawa
a63cd90876 Widget: signal new data for No1F1 and ZeTime also 
Pebble is still missing - since data is pushed and not fetched...
Will think about it.
 2019-09-16 22:31:36 +02:00
Andreas Shimokawa
89c7066d32 Widget: Only signal new data only when syncing activity data (not on fetching logs etc), do the same for Mi Band 1 2019-09-16 22:25:58 +02:00
Sebastian Kranz
0a6d0bd178 Add method to set the language of the watch. Note: Android Studio seems to have done automatic code formatting here. 2019-09-14 00:20:07 +02:00
Andreas Shimokawa
876515f1fd Amazfit Cor: support custom emoji font 
This commit refactors code and implements a custom device specific string
filter, which does nothing by default.
The implementation in HuamiSupport does the custom emoji conversion.

The setting has been moved from devicesettings_amazfitbip.xml to an extra file
As soon as there is a custom font for Mi Band 2/3/4 it is sufficient to add
"devicesettings_custom_emoji_font.xml" to the list of supported settings
in the appropriate coordinator and everything will work.
 2019-09-14 00:05:39 +02:00
Andreas Shimokawa
8eb494ab85 Widget: some cleanups 
- use LocalBroadcastManager when broadcasting new data event
- use constants for actions everywhere and move them
 2019-09-01 22:09:09 +02:00
vanous
957d441859 Add Status and Alarms widget 
Squashed commits from #1604
 2019-09-01 21:35:53 +02:00
Nephiel
b40c3ade85 Amazfit Bip: Add emoji support when using custom font firmware 2019-08-31 22:32:18 +02:00
Andreas Shimokawa
ce9eab8def Mi Band 4: really fix sending weather location 
Really fixes #1609
 2019-08-31 22:14:50 +02:00
Andreas Shimokawa
8f4489a21c Mi Band 4: Fix call notifcation not stopping when call gets answered or rejected on the phone 
This changes the way to how to stop call notification for all Huami device back to Mi Band 2
Also clean up unused code

Fixes #1612
 2019-08-29 08:32:29 +02:00
Andreas Shimokawa
243eec042d Mi Band 3/4, Amazfit Bip/Cor: Add setting to expose the HR sensor to 3rd party apps 
Closes #1606
 2019-08-27 11:13:45 +02:00
Andreas Shimokawa
da2e073dc2 Mi Band 4: Whitelist latest stable and beta firmware 2019-08-25 20:23:53 +02:00
Andreas Shimokawa
d07ca6faa6 Mi Band 4: Fix location not being updated on the Band 
Also move generic code from AmazfitBipSupport to HuamiSupport where is belongs
Fixes #1609
 2019-08-25 09:56:06 +02:00
Andreas Shimokawa
8bed673a95 Annotate LineageOsWeatherReceiver as Android >=M, and only try to use it with Oreo or later 2019-08-22 21:31:08 +02:00
keeshii
a70aa5e749 Added LineageOs Weather receiver. 2019-08-22 21:28:13 +02:00
Andreas Shimokawa
c1145e1244 Mi Band 4: Support flashing the V2 font that came with beta FW 1.0.6.00 
Only tested with 1.0.6.00
It now contains new characters like äöüß and others.
 2019-08-21 23:24:51 +02:00
Andreas Shimokawa
d7c6fad235 Mi Band 4: decode swim info (not used yet) 
After swimming a lot on the sofa and desk this seems right and in line with the data displayed on the band
swimming styles I got so far are breast and freestyle. Others are probably missing.

Might be correct for Cor also (I don't have one)
 2019-08-15 11:14:41 +02:00
Andreas Shimokawa
13b078aadd fix verison typo (before I get a PR again :P) 2019-08-14 19:40:10 +02:00
Andreas Shimokawa
c17c3ed341 Improve parsing and debug output for activity summaries from Mi Band/Amazfit 2019-08-14 19:24:09 +02:00
Andreas Shimokawa
b5ea3ca591 Hexdump sports activity packets for better analysis 
type 2 seems to be pause, 3 resume.
type 8 and seems to be related to swimming activites
 2019-08-13 23:02:10 +02:00
Andreas Shimokawa
f99bc0de64 Move another file from AmazfitBip to Huami which is no longer Bip specific 2019-08-13 22:20:18 +02:00
Andreas Shimokawa
ff7886765f Add Swimming to sport activity types, rename some AmazfitBip stuff to Huami (these were things introduced with the bip but working with other devices now also) 2019-08-13 22:04:52 +02:00
Andreas Shimokawa
0fd4d523a0 Amazfit Bip: Whitelist new firmware versions I tested 2019-08-07 17:24:01 +02:00
Andreas Shimokawa
461842a945 fix copyright header for newly added file 2019-08-02 23:52:25 +02:00
Andreas Shimokawa
02d02d2329 Add Initial Mijia LYWSD02 support (Smart Clock with Humidity and Temperature Sensor) 
This only sets the time on connect.
 2019-08-02 23:49:14 +02:00
Andreas Shimokawa
aefd7520f3 Mi Band 3/4, Amazfit Cor/Bip: set language immediately when changing it (not only on connect) 
Helps testing
 2019-08-02 00:11:11 +02:00
Andreas Shimokawa
97540d734f Mi Band 3/4: Allow enabling the "NFC" menu where supported 
Pretty useless, because we do not support NFC - but nice for testing
 2019-08-01 23:07:28 +02:00
dakhnod
961eb1c4ce adjusted battery threshold 2019-08-01 01:02:48 +02:00
dakhnod
32a2402048 removed Toast.makeText 2019-07-26 18:11:29 +02:00
dakhnod
f4d484f698 removed getDelegate() 2019-07-26 18:00:31 +02:00
dakhnod
1e936e4a85 Merge branch 'master' of github.com:Freeyourgadget/Gadgetbridge into fossil-q-hybrid 2019-07-26 17:57:12 +02:00
dakhnod
0b572505b3 removed DeviceSupportService hack 2019-07-26 16:42:53 +02:00
Andreas Shimokawa
17599a797a remove unused imports 2019-07-25 22:33:41 +02:00
Andreas Shimokawa
31db568832 Mi Band 4: Fix RES and FW update 2019-07-25 22:18:48 +02:00
Andreas Shimokawa
b6e78c1b9c Mi Band 4: Support flashing watchfaces 
FLASHING FIRMWARE/RES/FONT IS STILL UNTESTED
 2019-07-25 20:51:28 +02:00
dakhnod
1af8daba7a added SetTime request 2019-07-25 11:47:08 +02:00
dakhnod
4772ec714c addad DEVICE_CHANGED Intent 2019-07-25 11:38:56 +02:00
dakhnod
ca26d856ba code cleanup 2019-07-25 11:34:37 +02:00
dakhnod
886113dad8 tweaked init process 2019-07-25 11:30:33 +02:00
dakhnod
ef692498af Merge branch 'master' of github.com:Freeyourgadget/Gadgetbridge into fossil-q-hybrid 2019-07-25 11:12:50 +02:00
dakhnod
d802aa4ab1 added hardware version dependant function limiting 2019-07-25 11:12:24 +02:00
dakhnod
2ca1d69a17 reformatting 2019-07-25 10:56:03 +02:00
dakhnod
3f79592588 reworked init process 2019-07-25 10:52:27 +02:00
dakhnod
8f996e04cd Added device information and reworked notifications 2019-07-25 10:30:18 +02:00
dakhnod
8775255d69 Added Request 2019-07-25 10:29:45 +02:00
Andreas Shimokawa
5ff5561772 Mi Band 4: Fix notification icons and cut-off text 2019-07-24 09:33:53 +02:00
Andreas Shimokawa
044f6c11cd Mi Band 4: WIP firmware update preparation 
Nothing works yet
 2019-07-23 23:49:21 +02:00
Andreas Shimokawa
9042966a40 Mi Band 4: Fix empty notifications 
Icon still missing
 2019-07-23 22:42:30 +02:00
dakhnod
57e28c2dd0 added SetCountdownSettings Request (with buff) 2019-07-23 22:26:51 +02:00
dakhnod
9d251d99d2 Merge branch 'master' of github.com:Freeyourgadget/Gadgetbridge into fossil-q-hybrid 2019-07-23 20:30:18 +02:00
dakhnod
8bda4790a9 added GetCountdownSettings Request 2019-07-23 20:30:00 +02:00
Andreas Shimokawa
a60268c05c Mi Band 4: Bring your own key support (blindly done, I dont have my key) 
THIS STILL REQUIRES MI FIT AND YOUR EXTRACTED KEY

HOWTO:
1) press + button in Gadgerbridge
2) LONG PRESS Mi Band 4
3) Tap "Auth Key"
4) Enter your key prefixed with 0x (eg. 0x112233445566778899aabbccddeeff00)
5) Go back
6) Tap Mi Band 4

Success? You tell me.
 2019-07-23 08:56:26 +02:00
dakhnod
c0eb1420b2 adjusted initial sync 2019-07-21 17:21:42 +02:00
dakhnod
84952543e4 cosmetics 2019-07-21 17:10:55 +02:00
dakhnod
62feefb67e reworked settings, nearly removed DeviceSupport Hack 2019-07-21 16:47:17 +02:00
dakhnod
7d015e3275 added different requests 2019-07-21 16:42:28 +02:00
dakhnod
e2a573e3e2 fixed button overwrite for commuter 2019-07-20 16:03:31 +02:00
dakhnod
c99a3c91b5 improved file upload error handling 2019-07-20 15:45:14 +02:00
dakhnod
f5c8ea39b1 Merge branch 'master' of github.com:Freeyourgadget/Gadgetbridge into fossil-q-hybrid 2019-07-18 11:24:15 +02:00
Andreas Shimokawa
8d50e8ef08 Mi Band 3: Allow setting date format in per-device settings 
Closes #1544
 2019-07-16 23:48:08 +02:00
Andreas Shimokawa
f7a4b3c06a Mi Band 3: whitelist firmware 2.4.0.20 
Closes #1557
 2019-07-16 16:24:45 +02:00
Andreas Shimokawa
9163faf726 Merge remote-tracking branch 'github/pr/1555/zetime' 2019-07-16 00:41:04 +02:00
root
09f6cada87 Fossil Q hybrid and Skagen support added 
Opening this branch for the second time inorder to purge certain files form the repo
 2019-07-14 19:45:40 +02:00
Sebastian Kranz
1cd9a09ce5 BUGFIX: Really fix the timestamps now for everyone, everywhere. calculate the correct UTC of different timezones and daylight savings. 2019-07-12 08:08:52 +02:00
Andreas Shimokawa
ce0bd27111 remove useless condition 2019-06-22 21:10:19 +02:00
Andreas Shimokawa
9385c26fae Add missing MIBAND4 to switch 2019-06-19 22:15:42 +02:00
Andreas Shimokawa
d48d3cdea3 Add untested Mi Band 4 support (basically runs on Mi Band 3 code) 
This is COMPLETELY untested, we do not have the device.
 2019-06-12 23:44:01 +02:00
Andreas Shimokawa
d779310962 Move "activate display on lift wrist" and "rotate wrist to switch info" to per-device settings 
"activate display on lift wrist" for Mi Band 2/3, Cor, Bip
"rotate wrist" only for Mi Band 2
 2019-06-05 16:00:18 +02:00
Andreas Shimokawa
16090f0e21 Move fake device offset to Mi Band 1 preferences, remove support for other devices 
Reasons for removal:
- I doubt we honored the offset correctly for new features anyway that are available on newer devices
- Newer devices have a display always displaying the wrong time
 2019-06-05 14:11:44 +02:00
Andreas Shimokawa
b6a015c18b move low-latency setting for Mi Band to per-device settings (only for Mi Band 1) 2019-06-05 12:48:33 +02:00
Andreas Shimokawa
d2988f987f Mi Band 3: Whitelist FW 2.4.0.12 
Closes #1530
 2019-06-05 12:29:25 +02:00
Andreas Shimokawa
78dd7ef153 Mi Band 3: Fix setting menu items with 2.4 firmware and add support for the new timer menu 2019-05-29 15:53:44 +02:00
Andreas Shimokawa
12e16ac04a add ignoring calls support to Amazfit Bip (probably Cor also and maybe Mi Band 3) 2019-05-25 22:19:19 +02:00
Andreas Shimokawa
e066e0fae3 Merge remote-tracking branch 'github/pr/1523/ignore_call' 2019-05-25 22:12:58 +02:00
Andreas Böhler
dc22aabb1c Add support for muting an incoming call 2019-05-25 15:56:21 +02:00
Andreas Shimokawa
93f288b936 Move "Do not disturb" settings from Mi Band / Amazfit settings to per-device settings (Mi Band 2 and Mi Band 3 only) 2019-05-24 23:47:57 +02:00
Andreas Shimokawa
d1ba702e75 add more settings migration for settings that are now per-device 2019-05-23 23:24:49 +02:00
Andreas Shimokawa
3440485a51 Mi Band 2: move settings to per-device settings 2019-05-23 21:33:35 +02:00
Andreas Shimokawa
34e0c4e8bc remove swipe unlock settings from cor (can only be set from the band itself) 2019-05-22 19:04:38 +02:00
Andreas Shimokawa
038f101a12 Migrate more settings to per-device settings 
Also add icons.
 2019-05-22 10:49:59 +02:00
Andreas Shimokawa
9bfef4cf4f Make per-device settings more versatile, move more settings 
This allows to construct per-device settings by device type very easily

device coordinators just do the following to declare which setting they support,
the settings activity is then composed at runtime.

@Override
public int[] getSupportedDeviceSpecificSettings(GBDevice device) {
     return new int[]{
            R.xml.devicesettings_miband3,
            R.xml.devicesettings_swipeunlock,
            R.xml.devicesettings_pairingkey
    };
}
 2019-05-22 00:42:22 +02:00
Andreas Shimokawa
49667451d7 Mi Band 3: fix setting language (regression after todays refactoring) 2019-05-20 23:27:17 +02:00
Andreas Shimokawa
08e7d728c2 Huami: Migrate some settings to device specific settings 
- Migrate language setting
- Migrate menu items setting
- Migrate lastsync timestamp from prefixed global shared prefercence

All settings should be automatically be converted (e.g. Amazfit Bip settings to all paired Amazfit Bip devices) and then deleted.

Cor Settings aleady completely vanished from the global settings menu.

When migration is done we will have a much cleaner settings menu. Will also remove confusion that some Cor settings have to be done in Bip settings.
 2019-05-20 16:36:06 +02:00
DerFetzer
dd067eddd7 Amazfit Bip: Add new latin languages 2019-05-14 20:58:07 +02:00
Andreas Shimokawa
6031586131 Mi Band 3 NFC: Whitelist FW 1.7.0.4 
Closes #1470
 2019-05-09 15:43:57 +02:00
Andreas Shimokawa
34b4943918 Also export and import device specific preference files 2019-05-09 14:55:37 +02:00
Andreas Shimokawa
41e607ce9b Amazfit Cor 2: Give own device type id, support flashing the firmware **UNTESTED** 2019-05-09 12:42:59 +02:00
Andreas Shimokawa
19be1121c9 Merge remote-tracking branch 'github/pr/1492/previous_app_management' 2019-05-09 11:34:56 +02:00
Andreas Shimokawa
2dc228029a Mi Band 3: Whitelist FW 2.3.0.28 2019-05-09 11:28:24 +02:00
Andreas Shimokawa
f7fe3a836f Mi Band 3: Support flashing latest Japanese-Korean font file 
This increases the supported file size to 2.0MB.
Somehow it is confusing that the new file is version 1 and the old version 2.
Also according to firmare.json both are version 1....
 2019-05-07 11:13:48 +02:00
Andreas Shimokawa
0399bc048c Mi Band 3: Whitelist Firmware 2.3.0.6 2019-05-07 10:43:26 +02:00
Andreas Böhler
e82ac8dfd7 Make use of GattServer in BtLEQueue, improve initialization sequence, improve pairing sequence and fix a few bugs 2019-05-01 15:04:02 +02:00
Matej Drobnič
580d70e910 add pebblekit extension for reopening last app 2019-04-23 20:12:53 +02:00
Andreas Shimokawa
db48707764 Add a device specific settings activity, currently used for setting the auth key for Amazfit Bip/Cor 
When connecting to a new device, a random key gets generated, which can be
looked up from the device specific settings (accessible via the gear icon in
the device card in the main activity). Old devices keep their 0123456789@ABCDE
key, they have to be re-paired to change that.
During pairing, long-pressing the device candidate in the discovery activity
will also start the device specific settings activity, where the auth key
can be set manually priror to pairing. This is usefull to keep the ability to
pair one device with multiple android devices.

Fixes #1308
 2019-04-21 21:25:33 +02:00
License Bot
9aadb2f2fd Update license headers 2019-04-21 18:53:10 +02:00
Johannes Schmitt
f92626f4a5 moved BFH-16 in JYOU "group" 2019-04-20 22:00:50 +02:00
JoSch
7200538993 Update DeviceSupportFactory.java 
changed indent of MISCALE2
 2019-04-20 22:00:50 +02:00
Sophanimus
7acc3580dd added comment 2019-04-20 22:00:50 +02:00
Sophanimus
e86bc80016 improvements 2019-04-20 22:00:50 +02:00
Sophanimus
c7a6dc4b01 improvements 2019-04-20 22:00:50 +02:00
Sophanimus
070a132780 updated Copyright notes 2019-04-20 22:00:50 +02:00
Sophanimus
0b1f3ee1d7 added Copyright notes 2019-04-20 22:00:50 +02:00
Sophanimus
1087a53216 some functions do now work 
Signed-off-by: Sophanimus
 2019-04-20 22:00:50 +02:00
Sophanimus
6faf9fdae8 noticed similarities to JYOU, copyed JYOU functions, adapted heartrate, blood presure and satiation values 
Signed-off-by: Sophanimus
 2019-04-20 22:00:50 +02:00
Sophanimus
2c1f87c81b added BFH16DeviceSupport 
Signed-off-by: Sophanimus
 2019-04-20 22:00:50 +02:00
Andreas Shimokawa
665b1b6b5a Bip: whitelist FW 1.1.5.16 
Closes #1459
 2019-03-17 18:26:47 +01:00
criogenic
ff5ebe697b Update DeviceSupportFactory.java 
Insert break in CASIOGB6900 case.
 2019-03-07 19:20:06 +01:00
Andreas Shimokawa
46567b1e87 Fix build 
(...because we did not merge PRs in the correct order)
 2019-03-05 22:32:49 +01:00
cpfeiffer
c9f1c110b0 Merge remote-tracking branch 'github/pr/1292' 2019-03-04 22:10:23 +01:00
Sebastian Kranz
0da866f70a Change user goal distance preference to use meters instead of km. 2019-03-04 07:16:56 +01:00
Sebastian Kranz
71a1605445 Add function to save some big chunk of code at the preference listeners. 2019-03-04 06:34:10 +01:00
jfgreffier
072dcd28ec
Merge branch 'master' into master 2019-03-01 11:33:18 +01:00
cpfeiffer
f3a7861fdb Fix some lgtm warnings 2019-02-28 21:57:45 +01:00
cpfeiffer
ebdf385baa Temporarily add back CasioGATTServer so that we can merge #1404 2019-02-27 21:36:00 +01:00
cpfeiffer
930a3ad9b2 Merge remote-tracking branch 'github/pr/1404' 2019-02-27 21:06:50 +01:00
cpfeiffer
8d6a9d98da Silence lgtm error messages 
If the index would indeed be out of bounds, we would simply catch the exception and deal with that.
 2019-02-27 20:52:16 +01:00