Andreas Shimokawa
f2bfab0491
Huami: do not write elevation to GPX if we have a base altitude of -20000
...
( #2001 )
2020-09-03 23:01:59 +02:00
TaaviE
4aea2e626c
Improve icon size consistency in ControlCenterv2 ( #2000 )
...
Tinted the ic_delete_forever.xml correctly
Updated the default icon to look consistent with the rest
Due to being used in FABs, made ic_add white by-default and tinted ic_block properly
Adjusted Amazfit Bip and the ic_no_watch drawables to look more uniform with the rest
Re-imported the Amazfit Bip icon to fit the rest
Re-imported all material.io icons with the same DPI, renamed to original names, optimized and tinted every icon the same way
Updated the ic_switch_left icon to look better on smaller screens
scale refresh in control center to match the rest
Improved the icon size consistency in ControlCenter
Co-authored-by: TaaviE <taavi.eomae@gmail.com>
Co-authored-by: vanous <petr@linuks.cz>
Reviewed-on: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/2000
2020-09-01 21:27:07 +02:00
Andreas Shimokawa
9c239ec371
Amazfit Cor/Cor2: Allow workout syncing
2020-09-01 20:05:06 +02:00
TaaviE
116b2572dd
Avoided a NullPointerException when queue is null
2020-08-30 17:19:56 +02:00
TaaviE
cbc99b49ab
Caught an another exception that occurs when there's no access to the notifications
2020-08-30 17:53:50 +03:00
frederic lesur LESUR Frederic
c67ec5f71c
Change id of Lemfo SG2 to 44
...
Change name from SG2 to Lemfo SG2
2020-08-29 23:17:42 +02:00
frederic lesur LESUR Frederic
997504c01a
Add first support of SG2 HPlus watch
2020-08-29 23:17:42 +02:00
vanous
4c1208400e
Ensure that Sports Activity Filter has correct first item. Make Sports Filter buttons follow default theme
2020-08-29 02:19:06 +02:00
TaaviE
6cd59fbd24
Refactored all pairing and bonding activities ( #1989 )
...
Fixed a few warnings
Refactored all bonding and bonding activities
Co-authored-by: TaaviE <taavi.eomae+github@gmail.com>
Reviewed-on: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/1989
2020-08-28 15:38:18 +02:00
TaaviE
c5daa28214
Optimized vector images ( #1996 )
...
Improved the screenshot vector image a bit to look more uniform with the rest
Improved the about activity a bit for Android 10+
Cleaned up and optimized all vector drawables
Co-authored-by: TaaviE <taavi.eomae@gmail.com>
Reviewed-on: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/1996
2020-08-28 13:21:21 +02:00
vanous
39a472216a
Better handling of end of summary items list
2020-08-26 21:12:54 +02:00
vanous
723bd6fb6e
Controllable backgroundColor to item view. Split lines Activity Kind and Activity Name Label to prevent overflow
2020-08-26 20:45:38 +02:00
TaaviE
3bf2d4f086
Fixed a warning with witdh
being used as height
parameter.
2020-08-26 14:02:22 +02:00
Bot
40852d3641
Fixed a bunch of misspellings and formatting
2020-08-26 14:37:40 +03:00
Andreas Shimokawa
c9d98e60a9
Huami: Mark all devices as supporting device actions except mi band 2 (need to check that one, assuming newer ones to work)
...
Also add high_mtu setting to Rex, GTR, GTS, Mi Band 5
2020-08-26 10:00:06 +02:00
TaaviE
010785113b
Fixed a few more warnings
2020-08-26 09:38:31 +02:00
TaaviE
7db3b68047
Fixed a bunch of warnings
2020-08-26 09:38:31 +02:00
vanous
db29de4a9c
Material design Edit Icon, unified in Device alias and Activity name
2020-08-25 15:29:55 +02:00
vanous
df6f59213b
Make nicer format for Date/Time in ActivitySummaryList
2020-08-24 16:54:05 +02:00
vanous
34eee787d7
Add margins to AlertDialog.Builder
2020-08-24 13:50:10 +02:00
vanous
9b30369a88
Add edit Sport Summary Name. Add filtering by this name.
2020-08-24 00:09:10 +02:00
Andreas Shimokawa
c990a4f6fc
Pinetime JF: Fix setting the time
2020-08-23 17:27:32 +02:00
Andreas Shimokawa
52f15e331c
Pinetime JF: display firmware and hardware revisions, work around missing byte in notifications
2020-08-23 17:18:53 +02:00
Andreas Shimokawa
ef3edd9932
Huami: igrore min/max pace for certain workout types they all display the same bogus value
2020-08-23 15:03:40 +02:00
vanous
7b46a5e950
Tweak Sports Filter when a GBActivity now...
2020-08-23 13:01:54 +02:00
Andreas Shimokawa
b6abcc8c7b
Huami; swap min/max pace in parser
2020-08-23 00:14:36 +02:00
vanous
f8d22e9ec7
Make Filter be a normal activity. Fix s/m→m/km conversion
2020-08-23 00:04:23 +02:00
vanous
78745420ca
Make Sports Activity Detail data take full width
2020-08-23 00:04:23 +02:00
Andreas Shimokawa
645c22b10a
Huami: decode average HR where available (newer devices)
2020-08-22 21:59:18 +02:00
Andreas Shimokawa
fcb1df6c68
Huami: decode some more sports summary values on Bip S (probably other new devices also)
2020-08-22 21:53:26 +02:00
vanous
f05ad85f73
Make string values of summary data translatable
2020-08-22 10:31:32 +02:00
vanous
b236a6af16
Add Activity Summary Statistics Drawer
...
Move SummaryStatistics JSON Summary to own place
2020-08-21 23:51:46 +02:00
Andreas Shimokawa
ebc70b3fd5
TinyWeather: Patch incoming current weather with current timestamp
2020-08-20 23:07:24 +02:00
Andreas Shimokawa
f05ddd2d24
display swim style as string
2020-08-20 22:27:33 +02:00
Andreas Shimokawa
98b71e78bc
Parse swim summary data from Bip S (version 518)
...
This still looks wrong for some values
2020-08-19 23:37:10 +02:00
vanous
03b45d1071
Add better Sport Activities Filering
2020-08-19 19:45:23 +02:00
Andreas Shimokawa
164c73c955
WatchXPlus: Fix code setting units to imperial
...
Fixes #1955
2020-08-18 17:51:59 +02:00
Andreas Shimokawa
c800a18a46
Prevent NPE in notification filter code
...
Closes #1984
2020-08-18 15:58:18 +02:00
Andreas Shimokawa
715fb67859
Do summary parsing on the fly if raw binary data is available
2020-08-18 10:39:44 +02:00
Andreas Shimokawa
034b6d01e9
add yoga icon
2020-08-17 14:13:48 +02:00
Gordon Williams
8599d2f8db
Add wind speed to JSON produced for Bangle.js - fixes https://codeberg.org/Freeyourgadget/Gadgetbridge/issues/1974
2020-08-17 11:06:16 +01:00
Andreas Shimokawa
2ca2636142
Huami: Recognize missing workout types from the Bip S (and other devices where those are supported)
2020-08-16 23:45:52 +02:00
Andreas Shimokawa
28a3ab1518
Huami: save raw summary data in new binary blob column for later interpretation
2020-08-16 22:50:59 +02:00
vanous
20faa23843
Add events forwarding for HUAMI Bip, MB3 ( #1980 )
...
Remove unneeded function call
Re-done to simplify
Add media actions
Rename function to make meaning clearer
Add events forwarding for HUAMI Bip, MB3
Co-authored-by: vanous <petr@linuks.cz>
Reviewed-on: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/1980
2020-08-16 22:07:55 +02:00
vanous
19ac94e138
Make alternate row color honor set theme
2020-08-16 20:45:03 +02:00
vanous
78cd8e55b7
Add back arrow ← to Sports Activity Detail
2020-08-15 14:54:24 +02:00
vanous
7cc4b16852
Animate on swipe when at end ranges of Sport Activity Detail data
2020-08-15 14:11:35 +02:00
Andreas Shimokawa
e73c881aa9
Revert "swap +/- :)"
...
This reverts commit e027f3d526
.
2020-08-14 22:54:39 +02:00
vanous
c21206fbe4
Swapping min/max elevation
2020-08-14 22:53:00 +02:00
vanous
ed5b4ac793
SwipingView of Sports Activity Detail ( #1977 )
...
Swipable view done
WIP. Basic POC.
Co-authored-by: vanous <petr@linuks.cz>
Reviewed-on: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/1977
2020-08-14 22:48:03 +02:00
TaaviE
8a4be070ab
Added a custom icon for PineTime
2020-08-12 08:48:35 +02:00
vanous
f4bf457232
Add filter to Sports Activities
2020-08-12 07:36:53 +02:00
Andreas Shimokawa
e208549d1d
Decode a bit more for new acticity summaries (Bip S)
...
This also adds disabled code to create a binary dump for better analysis
2020-08-11 00:06:24 +02:00
vanous
3bff745b38
Make icon long press to toggle raw/calculated data
2020-08-10 22:40:58 +02:00
vanous
e027f3d526
swap +/- :)
2020-08-10 18:27:30 +02:00
vanous
f08b109deb
Finalized Sports view. Recalculate seconds to duration.
2020-08-10 18:23:16 +02:00
vanous
4a4362eec4
Use textViews. Remove groups from data.
2020-08-10 10:56:54 +02:00
Andreas Shimokawa
555eb34575
Start to support activity summary version 518
...
Incomplete, lot of missing stuff. no swimming, etc.
2020-08-10 00:19:13 +02:00
vanous
ec3334f037
move averageStride to Activity
2020-08-09 21:56:58 +02:00
vanous
bce85beb21
Use localized names and dates. Pass only needed data between activities.
...
Better display view. Cleaning up.
Add km/h and calculate speed to it.
Special casing calc not per key but per unit
solved min/maxPace, localized several missing labels.
totalStride is Total strides in m. Fix missing start_label
2020-08-09 21:56:31 +02:00
Andreas Shimokawa
c20810059d
Fix crash when opening GPX file, reformat code
2020-08-09 21:56:31 +02:00
vanous
c3887ddb86
minimum working version
2020-08-09 21:56:25 +02:00
vanous
7a46d39193
ActivityDetail with steps
2020-08-08 08:40:23 +02:00
Andreas Shimokawa
94afcba363
Add text column to BaseActivityData for storing unstructured data to be displayed later
...
As a test first test, this currently only stores the average heart rate.
2020-08-07 23:12:29 +02:00
Andreas Shimokawa
9b8f4d329e
Experiment with Pinetime-JF
2020-08-04 22:38:11 +02:00
Andreas Shimokawa
66f2eb8479
Amazfit Bip S: whitelist firmware 2.1.1.26 and 2.1.1.36
2020-08-03 22:42:07 +02:00
TaaviE
fb70a07f64
Tried fixing a LineageOS quirk with regular BT scans
2020-08-02 23:59:42 +03:00
TaaviE
749cf91f63
Handled the potential case of the same scan finishing twice and canceling a running scan being displayed
2020-08-02 23:43:00 +03:00
TaaviE
83f3b8565e
Removed duplicate UI updates
2020-08-02 22:06:18 +03:00
TaaviE
d7ce49a2f3
Improved UX when Bluetooth is disabled mid-scan
2020-08-02 21:55:16 +03:00
TaaviE
9627360fac
Fixed an UI error when Bluetooth discovery starting fails
2020-08-02 21:23:14 +03:00
TaaviE
61c74e9b15
Made the scans time out nicely
2020-08-02 21:07:14 +03:00
TaaviE
498c0d42e2
Made sure to check if location permission has been given by the user for scanning
2020-08-02 21:07:14 +03:00
TaaviE
aa9abd4b61
Added a log message that might help with debugging in some cases
2020-08-02 21:07:14 +03:00
TaaviE
f526bbe632
Added an API version guard to the new type of BLE scanning
2020-08-02 21:07:14 +03:00
TaaviE
b76a8267b8
Added CompanionDeviceManager support, added target 29 support, refactored the scan display and UI.
2020-08-02 21:07:14 +03:00
TaaviE
1b43468b9e
Improved the ITag coordinator class a bit
2020-08-02 21:07:14 +03:00
Andreas Shimokawa
a619fdb168
Huami: Prevent setting an MTU of < 23, which is either a special value or a parsing error of Gadgetbridge
...
This fixes a problem where writeToChunked algorithm results in out of bounds writes or an endless loop.
Closes #1936
2020-08-02 13:11:41 +02:00
TaaviE
f9dc625c5c
Printed a few rather fatal exceptions in case they happen for easier debugging ( #1946 )
...
Removed a few more occurrences of double logging
Removed double logging
Printed a few rather fatal exceptions in case they happen for easier debugging and a few other small cleanups
Co-authored-by: TaaviE <taavi.eomae+github@gmail.com>
Reviewed-on: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/1946
2020-08-02 10:55:06 +02:00
TaaviE
2ba6b88ff9
Made scan results a bit more detailed by displaying special cases
2020-08-02 03:33:08 +03:00
Cristian Alfano
637a7d5d07
Adding support for Mi Band 5's new FW and res versions and new languages supported: italian, french and german.
2020-08-01 23:03:21 +02:00
TaaviE
da529579f4
Made it possible to disable asking for a few permissions.
2020-08-01 17:27:26 +03:00
TaaviE
1ceaf48ba7
Only request ANSWER_PHONE_CALL above API 26
2020-08-01 17:27:15 +03:00
TaaviE
bb1b31bcb4
Made sure to check notification listener access even after first launch because not having it can cause issues
2020-08-01 17:27:15 +03:00
TaaviE
8da7a7aced
Added a checkbox to un-ignore bonded devices
2020-08-01 15:49:54 +02:00
Andreas Shimokawa
c735dd0dd4
fix compilation
2020-07-31 14:05:45 +02:00
115ek
58711ff2d2
TLW64: Add basic settings
...
* inactivity warnings
* activate display on lift
* timeformat
* TODO: screen timeout, find-my-device,...
2020-07-30 15:00:34 +02:00
115ek
81956143de
TLW64: Revert "Switch to dynamic battery detection"
...
This reverts commit 8c7800534f78258b9f817ac3a524d985ed6aa84e.
* Battery Service doesn't notify so the charge gets only updated on initializeDevice()
2020-07-30 12:36:02 +02:00
115ek
7a2cb1ca68
TLW64: Fix fetching progress bar
...
* Fetching progress bar wasn't made invisible again
2020-07-30 12:36:02 +02:00
115ek
943728c35c
TLW64: Support fetching activity data (steps + sleep)
2020-07-30 12:35:43 +02:00
115ek
95da81dfcf
TLW64: Increase vibration amount on call state
...
* 5 vibrations are too less if someone calls
* 30 vibrations last about 30 seconds (if call state doesn't change)
* duration parameter behaves strange: higher value means shorter vibration?!
-> let's go back to default duration of 1
2020-07-30 12:15:12 +02:00
115ek
4f5e2d0730
TLW64: Beautify code
2020-07-30 12:15:12 +02:00
115ek
8a3174dabd
TLW64: Support further device settings
...
* inactivity alarm
* others are unclear
2020-07-30 12:15:12 +02:00
115ek
5c40e71355
TLW64: Support alarms
2020-07-30 12:15:12 +02:00
115ek
098120ea56
TLW64: Switch to dynamic battery detection
...
* Battery Service 0x180F is supported so let's make use of it
2020-07-30 12:15:12 +02:00
115ek
92d2fbc997
TLW64: Support battery level and firmware version detection
...
* firmware is missing some characters compared to the value reported by the original app
* https://play.google.com/store/apps/details?id=com.yc.pedometer&hl=en_US
* need to investigate that
2020-07-30 12:15:12 +02:00
115ek
4cb481fba3
TLW64: Wiretap operation
...
* let's log some packets to make sure we send the right things
2020-07-30 12:15:12 +02:00
115ek
1e6146f4aa
TLW64: Support factory reset
2020-07-30 12:15:12 +02:00
115ek
654019e2c0
TLW64: Support notifications
2020-07-30 12:15:12 +02:00
115ek
fc2a7c6f8d
TLW64: Support setting userdata
2020-07-30 12:15:12 +02:00
115ek
56dc5211e7
TLW64: Support setting displaysettings
...
* 24h/12h clock
* metric/imperial units
2020-07-30 12:15:12 +02:00
115ek
0ed7c385fb
TLW64: Support setting date
2020-07-30 12:15:12 +02:00
115ek
7c5a2d0e58
TLW64: Support find device
2020-07-30 12:15:12 +02:00
115ek
dfd2eb0e10
TLW64: Initial support
2020-07-30 12:15:12 +02:00
TaaviE
629a3bcf63
Improved when and how the toast to grant permissions is displayed, won't request permissions that have been permanently disabled or denied by the system. No way to actually ask if the permission has been denied by the user.
2020-07-30 00:04:36 +02:00
odavo32nof
d3a51a1078
Adding Mi Band 5 initial support ( #1930 )
...
Merge branch 'master' into master
Merge branch 'master' into master
Added available languages for Mi Band 5.
This one's for fixing the step counter but the daily count is always a little bit different compared to what's shown on the smartband.
Extending Mi Band 5 support! Every display item can be showed on the smartband now.
Cleanup
FW related test code
FW related test code
FW related test code
FW related test code
Adding Mi Band 5 test support
Co-authored-by: cristian <c.alfano@outlook.it>
Reviewed-on: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/1930
2020-07-28 18:16:56 +02:00
TaaviE
22256030b5
Made items in the media receivers list more differentiable
2020-07-28 16:55:25 +02:00
TaaviE
701039e673
Instead of crashing, display a notification that the service couldn't be started
2020-07-28 11:57:13 +03:00
TaaviE
3ad1412a1d
Delegated error handling properly to the function that creates FetchActivityOperation
2020-07-28 08:11:50 +02:00
TaaviE
bcac8e0d7f
Minor changes and a fix to a NPE when mBtGatt is null
2020-07-28 08:10:39 +02:00
TaaviE
443658bf9e
Caught an illegal argument instead of crashing and made it clear that continuing is ill-advised
2020-07-28 08:08:16 +02:00
TaaviE
709fb0a82b
Made UriHelper a bit more failure resistant
2020-07-28 01:16:17 +03:00
TaaviE
1c2cd99efd
Made sure to request the permission to change ringer mode to silent
2020-07-27 21:21:19 +03:00
TaaviE
18afddac29
Made the version string generation use a specific locale for generation, trying to avoid potential localization issues
2020-07-27 20:11:37 +02:00
TaaviE
7ea7fadd60
Made Mi Band activity fetching not crash the application
2020-07-27 17:55:16 +03:00
Andreas Shimokawa
932b0f7f94
Amazgit GTR/GTR Lite: Try to fix broken activity data
...
Query versions as described in #1907
Also see #1924
2020-07-23 22:05:28 +02:00
Andreas Shimokawa
ef09e24482
Amazfit GTS: Fix broken activity data on Firmware 0.0.9.xx
...
Fixes #1924
2020-07-22 11:03:30 +02:00
Andreas Shimokawa
f460f6abd1
Amazfit Bip S: Change Unknown menu item to "World Clock"
...
Latest firmware has a world clock, setting the locations is not yet supported by Gadgetbridge
2020-07-21 17:13:23 +02:00
vanous
2496b40a88
Improve padding. Use better (i) icon. Add 'unlisted contributors'.
2020-07-12 10:38:56 +02:00
vanous
c1a8fb502c
Add About screen
2020-07-11 17:04:29 +02:00
Michael
3695a68e2f
Add drawables for Amazfit Bip smartwatch
...
- It is my own work based on a picture of my Amazfit Bip.
- I added the resources and changed DeviceType.java to use the new drawables for all Amazfit watches similar to Bip (Bip, Bip s, Bip lite and GTS).
- I added the license to LICENSE.artwork
2020-07-09 14:09:48 +02:00
Andreas Shimokawa
7980d928a8
Add experimental support for TinyWeatherForecastGermany
2020-07-05 21:54:10 +02:00
Andreas Shimokawa
c437347236
Amazfit GTR/GTS: Fix connection for new firmware
...
This change does not do any harm on other Huami devices it seems
2020-07-05 17:07:43 +02:00
Andreas Shimokawa
3940387b1a
Huami: set forecast limit to 6 days (current + 6 in future)
2020-06-29 19:41:56 +02:00
Andreas Shimokawa
b7a1f469ee
Huami: limit forecast days to 3 days
...
Fixes problems with new weather notificaion on Mi Band 4 and others
Fixes #1910
2020-06-29 19:02:30 +02:00
Andreas Shimokawa
425bf48df5
Amazfit Bip S: whitelist fw 2.1.1.16
2020-06-29 16:36:16 +02:00
Andreas Shimokawa
c1b6f5f4f5
Amazfit Bip S: fix installation of latest res (96)
2020-06-29 00:17:23 +02:00
Dmytro Bielik
496460502b
Initial support for Amazfit T-Rex
2020-06-24 18:43:23 +03:00
Andreas Shimokawa
5d58a2f583
Work around music controls being disabled since last commit on Amazfit Cor (we do not get a music app started event before we haven't sent music information - weird)
2020-06-22 18:35:22 +02:00
Andreas Shimokawa
6b20f62e0f
Huami: Use music control code from Bip S for all devices
...
needs testing and cleanup for all devices
2020-06-22 18:06:40 +02:00
Zhong Jianxin
55f9c8f519
Huami: Avoid cutting multibyte chars in half
2020-06-22 10:12:10 +02:00
Dmitry Markin
a8638a52fa
Stop an incoming call notification when a VoIP call is missed
2020-06-20 11:52:49 +03:00
TaaviE
d871b03f33
Added a safety measure against a weird internal crash when stopping a BLE scan
2020-06-17 08:47:39 +02:00
Zhong Jianxin
c3a9cf858e
Amazfit Bip S: Allow longer notification message
2020-06-16 13:41:26 +08:00
Andreas Shimokawa
26b7932153
Mi Band 4: Whitelist FW 1.0.9.58
2020-06-13 22:18:18 +02:00
Andreas Shimokawa
0229d24092
Mi Band 4 (possibly others): Fix detected RES version being always 69 for non-whitelisted res files
...
Fixes #1886
2020-06-12 23:24:26 +02:00
Andreas Shimokawa
cdc149338a
Also use device alias if set in notification
2020-06-12 22:49:16 +02:00
Andreas Shimokawa
a8328d4a96
Add GUI to change alias ( closes #1888 )
...
Could look nicer...
2020-06-12 22:38:37 +02:00
Andreas Shimokawa
53f5439444
Start implementing device aliases ( #1888 )
2020-06-12 18:04:53 +02:00
Andreas Shimokawa
8400568aed
Amazfit Bip S: support flashing GPS firmware, whitelist tonlesap 2.1.1.08 firmware, res, gps, font
2020-06-12 16:58:02 +02:00
Andreas Shimokawa
1f8826329c
Amazfit Bip S: For firmware update distinguish dth and tonlesap variants
...
This is done by comparing the firmware version (2 assumed for tonlesap, 4 for dth)
This could have been done properly by comparing the hardware revision, but there are so many hardware revisions during a huami device lifecycle, we could not catch up.
2020-06-12 16:14:35 +02:00
Andreas Shimokawa
a19bb8c21d
* Amazfit Bip S: remove disconnect notification and button action settings (they do not work)
2020-06-12 09:46:48 +02:00
Andreas Shimokawa
99b7764709
Amazfit Bip S: Support flashing firmware and res
2020-06-11 19:24:45 +02:00
Andreas Shimokawa
25c749bab9
Amazfit Bip S: Support flashing fonts and setting high MTU
2020-06-11 13:29:41 +02:00
Andreas Shimokawa
8e08a9d660
Support flashing newer GPS ALM and support flashing GPS CEP on Bip S
2020-06-11 12:16:57 +02:00
Andreas Shimokawa
2f8634ce66
Shamelessly assume Bip S is using one of the newer fireware install code
2020-06-08 16:43:39 +02:00
Andreas Shimokawa
7d0243e61d
move Bip S file
2020-06-08 16:38:03 +02:00
Andreas Shimokawa
4326419209
Amazfit Bip S: allow flashing watchfaces (untested, and probably wont work)
2020-06-08 16:36:54 +02:00
Zhong Jianxin
44a9ce0267
Amazfit Bip S: Music support
2020-06-08 16:16:33 +02:00
Zhong Jianxin
c0558c570c
Huami: Check if musicSpec/stateSpec is null
2020-06-08 16:16:33 +02:00