From 6fd357962f5e26177842b5a1bb60f42d678def3b Mon Sep 17 00:00:00 2001
From: osm0sis <osm0sis@outlook.com>
Date: Sat, 2 Nov 2019 22:50:33 -0300
Subject: [PATCH] scripts: fix signing in recovery with addon.d-v1 - change to
 $TMPDIR in addon.d.sh since recovery addon.d-v1 backup + restore leaves you
 in /tmp/addon.d which the restore then deletes, which would break $BOOTSIGNER
 execution with the following:     libc: Fatal signal 11 (SIGSEGV), code 1
 (SEGV_MAPERR), fault addr 0x0 in tid 1078 (main), pid 1078 (main)    
 Segmentation fault - also move $BOOTSIGNER execution to after `cd $MAGISKBIN`
 to ensure it's in a working directory in all cases - addon.d.sh data mount
 wasn't doing anything since /data has to already be mounted for the script to
 be running, so move it into /system/addon.d/99-magisk.sh stub script where it
 might be useful on recoveries that don't mount /data initially

Fixes #2013
---
 scripts/addon.d.sh        | 6 ++++--
 scripts/flash_script.sh   | 2 ++
 scripts/util_functions.sh | 6 +++---
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/scripts/addon.d.sh b/scripts/addon.d.sh
index 53aa676c4..8aae989b6 100644
--- a/scripts/addon.d.sh
+++ b/scripts/addon.d.sh
@@ -20,9 +20,8 @@ else
 fi
 
 initialize() {
-  mount /data 2>/dev/null
-
   MAGISKBIN=/data/adb/magisk
+
   if [ ! -d $MAGISKBIN ]; then
     echo "! Cannot find Magisk binaries!"
     exit 1
@@ -46,6 +45,9 @@ main() {
     sleep 5
   fi
 
+  # Ensure we aren't in /tmp/addon.d anymore (since it's been deleted by addon.d)
+  cd $TMPDIR
+
   $BOOTMODE || recovery_actions
 
   ui_print "************************"
diff --git a/scripts/flash_script.sh b/scripts/flash_script.sh
index df92b5e48..6b8f6bbcc 100644
--- a/scripts/flash_script.sh
+++ b/scripts/flash_script.sh
@@ -84,6 +84,8 @@ if [ -d /system/addon.d ]; then
 #!/sbin/sh
 # ADDOND_VERSION=2
 
+mount /data 2>/dev/null
+
 if [ -f /data/adb/magisk/addon.d.sh ]; then
   exec sh /data/adb/magisk/addon.d.sh "\$@"
 else
diff --git a/scripts/util_functions.sh b/scripts/util_functions.sh
index 8977f28cb..25e5fdfe3 100644
--- a/scripts/util_functions.sh
+++ b/scripts/util_functions.sh
@@ -295,12 +295,12 @@ patch_dtbo_image() {
 
 patch_boot_image() {
   # Common installation script for flash_script.sh (updater-script) and addon.d.sh
-  eval $BOOTSIGNER -verify < $BOOTIMAGE && BOOTSIGNED=true
-  $BOOTSIGNED && ui_print "- Boot image is signed with AVB 1.0"
-
   SOURCEDMODE=true
   cd $MAGISKBIN
 
+  eval $BOOTSIGNER -verify < $BOOTIMAGE && BOOTSIGNED=true
+  $BOOTSIGNED && ui_print "- Boot image is signed with AVB 1.0"
+
   $IS64BIT && mv -f magiskinit64 magiskinit 2>/dev/null || rm -f magiskinit64
 
   # Source the boot patcher