From 9150bf720d2750747423f1186fa6af7007eb8f5a Mon Sep 17 00:00:00 2001
From: topjohnwu <topjohnwu@gmail.com>
Date: Sun, 5 Feb 2017 22:30:14 +0800
Subject: [PATCH] Add info for MagiskHide when not using MagiskSU Close #63

---
 .../com/topjohnwu/magisk/SettingsActivity.java     | 14 +++++++++++---
 app/src/main/res/values/strings.xml                |  3 +++
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/com/topjohnwu/magisk/SettingsActivity.java b/app/src/main/java/com/topjohnwu/magisk/SettingsActivity.java
index edfa307db..f0e2a043c 100644
--- a/app/src/main/java/com/topjohnwu/magisk/SettingsActivity.java
+++ b/app/src/main/java/com/topjohnwu/magisk/SettingsActivity.java
@@ -1,5 +1,6 @@
 package com.topjohnwu.magisk;
 
+import android.content.DialogInterface;
 import android.content.SharedPreferences;
 import android.os.Bundle;
 import android.preference.ListPreference;
@@ -182,9 +183,16 @@ public class SettingsActivity extends AppCompatActivity {
                     break;
                 case "magiskhide":
                     enabled = prefs.getBoolean("magiskhide", false);
-                    if (enabled)
-                        new Async.MagiskHide().enable();
-                    else
+                    if (enabled) {
+                        if (!Global.Info.isSuClient) {
+                            Utils.getAlertDialogBuilder(getActivity())
+                                    .setTitle(R.string.no_magisksu_title)
+                                    .setMessage(R.string.no_magisksu_msg)
+                                    .setPositiveButton(R.string.understand, (dialog, which) -> new Async.MagiskHide().enable())
+                                    .setCancelable(false)
+                                    .show();
+                        } else new Async.MagiskHide().enable();
+                    } else
                         new Async.MagiskHide().disable();
                     break;
                 case "hosts":
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index ab19d5f1a..390763f78 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -115,6 +115,9 @@
     <string name="repo_cache_cleared">Repo cache cleared</string>
     <string name="safetyNet_hide_notice">This app uses SafetyNet\nAlready handled by MagiskHide by default</string>
     <string name="start_magiskhide">Starting MagiskHide …</string>
+    <string name="no_magisksu_title">Not using MagiskSU!</string>
+    <string name="no_magisksu_msg">You are not rooted with MagiskSU, using MagiskHide itself might not be enough!\nIt\'s not officially supported, and you would need additional tools (e.g suhide) to pass Safety Net.</string>
+    <string name="understand">I understand</string>
 
     <!--URL Templates-->
     <string name="url_main" translatable="false">https://api.github.com/orgs/Magisk-Modules-Repo/repos</string>