From d462873e7486b9542f3743ebf3e2df8f645ed3b5 Mon Sep 17 00:00:00 2001
From: topjohnwu <topjohnwu@gmail.com>
Date: Tue, 6 Oct 2020 02:21:57 -0700
Subject: [PATCH] Prevent UI loop on low memory device

Fix #3215, close #3216
---
 .../magisk/ui/install/InstallFragment.kt      | 20 +++++++++++++++++++
 .../magisk/ui/install/InstallViewModel.kt     |  9 ++++++---
 2 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallFragment.kt b/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallFragment.kt
index ab5ffbc72..53cc4407e 100644
--- a/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallFragment.kt
+++ b/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallFragment.kt
@@ -1,5 +1,9 @@
 package com.topjohnwu.magisk.ui.install
 
+import android.os.Bundle
+import android.view.LayoutInflater
+import android.view.View
+import android.view.ViewGroup
 import androidx.lifecycle.viewModelScope
 import com.topjohnwu.magisk.R
 import com.topjohnwu.magisk.arch.BaseUIFragment
@@ -22,4 +26,20 @@ class InstallFragment : BaseUIFragment<InstallViewModel, FragmentInstallMd2Bindi
         BaseDownloader.observeProgress(this, viewModel::onProgressUpdate)
     }
 
+    override fun onCreateView(
+        inflater: LayoutInflater,
+        container: ViewGroup?,
+        savedInstanceState: Bundle?
+    ): View? {
+        viewModel._method = savedInstanceState?.getInt(KEY_CURRENT_METHOD, -1) ?: -1
+        return super.onCreateView(inflater, container, savedInstanceState)
+    }
+
+    override fun onSaveInstanceState(outState: Bundle) {
+        outState.putInt(KEY_CURRENT_METHOD, viewModel.method)
+    }
+
+    companion object {
+        private const val KEY_CURRENT_METHOD = "current_method"
+    }
 }
diff --git a/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt b/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt
index b6d479e46..1c8c4a8cc 100644
--- a/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt
+++ b/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt
@@ -31,13 +31,16 @@ class InstallViewModel(
     var step = if (skipOptions) 1 else 0
         set(value) = set(value, field, { field = it }, BR.step)
 
+    var _method = -1
+
     @get:Bindable
-    var method = -1
-        set(value) = set(value, field, { field = it }, BR.method) {
+    var method
+        get() = _method
+        set(value) = set(value, _method, { _method = it }, BR.method) {
             when (it) {
                 R.id.method_patch -> {
                     MagiskInstallFileEvent { code, intent ->
-                        if (code ==  Activity.RESULT_OK)
+                        if (code == Activity.RESULT_OK)
                             data = intent?.data
                     }.publish()
                 }