From eec5b37da1e35b21dc487b963570034e850c7ff9 Mon Sep 17 00:00:00 2001
From: Viktor De Pasquale <info@depasquale.wiki>
Date: Thu, 14 Nov 2019 15:12:53 +0100
Subject: [PATCH] Fixed inconsistent animations in hide

---
 .../topjohnwu/magisk/redesign/compat/CompatFragment.kt    | 8 ++++++--
 .../com/topjohnwu/magisk/redesign/hide/HideFragment.kt    | 2 ++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/com/topjohnwu/magisk/redesign/compat/CompatFragment.kt b/app/src/main/java/com/topjohnwu/magisk/redesign/compat/CompatFragment.kt
index a773770c1..f7eb35d72 100644
--- a/app/src/main/java/com/topjohnwu/magisk/redesign/compat/CompatFragment.kt
+++ b/app/src/main/java/com/topjohnwu/magisk/redesign/compat/CompatFragment.kt
@@ -24,8 +24,8 @@ abstract class CompatFragment<ViewModel : CompatViewModel, Binding : ViewDataBin
 
         binding.addOnRebindCallback(object : OnRebindCallback<Binding>() {
             override fun onPreBind(binding: Binding): Boolean {
-                (binding.root as? ViewGroup)?.startAnimations()
-                return super.onPreBind(binding)
+                this@CompatFragment.onPreBind(binding)
+                return true
             }
         })
 
@@ -42,6 +42,10 @@ abstract class CompatFragment<ViewModel : CompatViewModel, Binding : ViewDataBin
         delegate.onEventExecute(event, this)
     }
 
+    protected open fun onPreBind(binding: Binding) {
+        (binding.root as? ViewGroup)?.startAnimations()
+    }
+
     protected fun ViewEvent.dispatchOnSelf() = delegate.onEventExecute(this, this@CompatFragment)
 
 }
\ No newline at end of file
diff --git a/app/src/main/java/com/topjohnwu/magisk/redesign/hide/HideFragment.kt b/app/src/main/java/com/topjohnwu/magisk/redesign/hide/HideFragment.kt
index c375599d0..81879348a 100644
--- a/app/src/main/java/com/topjohnwu/magisk/redesign/hide/HideFragment.kt
+++ b/app/src/main/java/com/topjohnwu/magisk/redesign/hide/HideFragment.kt
@@ -65,6 +65,8 @@ class HideFragment : CompatFragment<HideViewModel, FragmentHideMd2Binding>() {
         return super.onOptionsItemSelected(item)
     }
 
+    override fun onPreBind(binding: FragmentHideMd2Binding) = Unit
+
 }
 
 object MotionRevealHelper {