From f3cd9a096a2ea3e526b4779c75794313330aeeb7 Mon Sep 17 00:00:00 2001 From: Viktor De Pasquale Date: Sat, 27 Apr 2019 11:49:25 +0200 Subject: [PATCH] Removed old Base[Activity/Fragment] --- .../magisk/ui/base/ActivityResultListener.kt | 7 + .../magisk/ui/base/BaseActivity.java | 166 ------------------ .../magisk/ui/base/BaseFragment.java | 61 ------- .../ui/base/BasePreferenceFragment.java | 2 +- .../topjohnwu/magisk/ui/base/IBaseLeanback.kt | 6 +- .../magisk/ui/base/MagiskLeanbackActivity.kt | 4 +- 6 files changed, 11 insertions(+), 235 deletions(-) create mode 100644 app/src/main/java/com/topjohnwu/magisk/ui/base/ActivityResultListener.kt delete mode 100644 app/src/main/java/com/topjohnwu/magisk/ui/base/BaseActivity.java delete mode 100644 app/src/main/java/com/topjohnwu/magisk/ui/base/BaseFragment.java diff --git a/app/src/main/java/com/topjohnwu/magisk/ui/base/ActivityResultListener.kt b/app/src/main/java/com/topjohnwu/magisk/ui/base/ActivityResultListener.kt new file mode 100644 index 000000000..16d963403 --- /dev/null +++ b/app/src/main/java/com/topjohnwu/magisk/ui/base/ActivityResultListener.kt @@ -0,0 +1,7 @@ +package com.topjohnwu.magisk.ui.base + +import android.content.Intent + +interface ActivityResultListener { + fun onActivityResult(resultCode: Int, data: Intent?) +} \ No newline at end of file diff --git a/app/src/main/java/com/topjohnwu/magisk/ui/base/BaseActivity.java b/app/src/main/java/com/topjohnwu/magisk/ui/base/BaseActivity.java deleted file mode 100644 index 59721eb43..000000000 --- a/app/src/main/java/com/topjohnwu/magisk/ui/base/BaseActivity.java +++ /dev/null @@ -1,166 +0,0 @@ -package com.topjohnwu.magisk.ui.base; - -import android.Manifest; -import android.content.Context; -import android.content.Intent; -import android.content.SharedPreferences; -import android.content.pm.ActivityInfo; -import android.content.pm.PackageManager; -import android.os.Build; -import android.os.Bundle; -import android.text.TextUtils; -import android.view.WindowManager; - -import com.topjohnwu.magisk.App; -import com.topjohnwu.magisk.Config; -import com.topjohnwu.magisk.Const; -import com.topjohnwu.magisk.R; -import com.topjohnwu.magisk.utils.Event; -import com.topjohnwu.magisk.utils.LocaleManager; - -import androidx.annotation.NonNull; -import androidx.annotation.Nullable; -import androidx.annotation.StyleRes; -import androidx.appcompat.app.AppCompatActivity; -import androidx.collection.SparseArrayCompat; -import androidx.core.app.ActivityCompat; -import androidx.core.content.ContextCompat; - -/** - * @deprecated This class is not to be used. It is marked for deletion. - */ -@Deprecated -public abstract class BaseActivity extends AppCompatActivity implements Event.AutoListener, IBaseLeanback { - - static int[] EMPTY_INT_ARRAY = new int[0]; - - private final SparseArrayCompat resultListeners = new SparseArrayCompat<>(); - public App app = App.self; - - @Override - public int[] getListeningEvents() { - return EMPTY_INT_ARRAY; - } - - @Override - public void onEvent(int event) {} - - @StyleRes - public int getDarkTheme() { - return -1; - } - - @Override - protected void attachBaseContext(Context base) { - super.attachBaseContext(LocaleManager.getLocaleContext(base, LocaleManager.locale)); - } - - @Override - protected void onCreate(@Nullable Bundle savedInstanceState) { - Event.register(this); - if (getDarkTheme() != -1 && (boolean) Config.get(Config.Key.DARK_THEME)) { - setTheme(getDarkTheme()); - } - super.onCreate(savedInstanceState); - } - - @Override - protected void onDestroy() { - Event.unregister(this); - super.onDestroy(); - } - - protected void setFloating() { - boolean isTablet = getResources().getBoolean(R.bool.isTablet); - if (isTablet) { - WindowManager.LayoutParams params = getWindow().getAttributes(); - params.height = getResources().getDimensionPixelSize(R.dimen.floating_height); - params.width = getResources().getDimensionPixelSize(R.dimen.floating_width); - params.alpha = 1.0f; - params.dimAmount = 0.6f; - params.flags |= 2; - getWindow().setAttributes(params); - setFinishOnTouchOutside(true); - } - } - - protected void lockOrientation() { - if (Build.VERSION.SDK_INT < 18) - setRequestedOrientation(getResources().getConfiguration().orientation); - else - setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_LOCKED); - } - - public static void runWithPermissions(Context context, String[] permissions, Runnable callback) { - boolean granted = true; - for (String perm : permissions) { - if (ContextCompat.checkSelfPermission(context, perm) != PackageManager.PERMISSION_GRANTED) - granted = false; - } - if (granted) { - Const.EXTERNAL_PATH.mkdirs(); - callback.run(); - } else { - // Passed in context should be an activity if not granted, need to show dialog! - if (context instanceof BaseActivity) { - BaseActivity activity = (BaseActivity) context; - int code = callback.hashCode() & 0xFFFF; - activity.resultListeners.put(code, (i, d) -> callback.run()); - ActivityCompat.requestPermissions(activity, permissions, code); - } - } - } - - @Override - public final void runWithExternalRW(Runnable callback) { - runWithPermissions(new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE}, callback); - } - - @Override - public final void runWithPermissions(String[] permissions, Runnable callback) { - runWithPermissions(this, permissions, callback); - } - - @Override - protected void onActivityResult(int requestCode, int resultCode, Intent data) { - onActivityResultListener(requestCode, resultCode, data); - } - - private void onActivityResultListener(int requestCode, int resultCode, Intent data) { - ActivityResultListener listener = resultListeners.get(requestCode); - if (listener != null) { - resultListeners.remove(requestCode); - listener.onActivityResult(resultCode, data); - } - } - - @Override - public final void startActivityForResult(Intent intent, int requestCode, ActivityResultListener listener) { - resultListeners.put(requestCode, listener); - startActivityForResult(intent, requestCode); - } - - @Override - public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) { - boolean grant = true; - for (int result : grantResults) { - if (result != PackageManager.PERMISSION_GRANTED) - grant = false; - } - if (grant) - onActivityResultListener(requestCode, 0, null); - else - resultListeners.remove(requestCode); - } - - public interface ActivityResultListener { - void onActivityResult(int resultCode, Intent data); - } - - @Override - public SharedPreferences getSharedPreferences(String name, int mode) { - if (TextUtils.equals(name, getPackageName() + "_preferences")) - return app.getPrefs(); - return super.getSharedPreferences(name, mode); - } -} diff --git a/app/src/main/java/com/topjohnwu/magisk/ui/base/BaseFragment.java b/app/src/main/java/com/topjohnwu/magisk/ui/base/BaseFragment.java deleted file mode 100644 index 10be31170..000000000 --- a/app/src/main/java/com/topjohnwu/magisk/ui/base/BaseFragment.java +++ /dev/null @@ -1,61 +0,0 @@ -package com.topjohnwu.magisk.ui.base; - -import android.content.Intent; - -import com.topjohnwu.magisk.App; -import com.topjohnwu.magisk.utils.Event; - -import androidx.fragment.app.Fragment; -import butterknife.Unbinder; - -/** - * @deprecated This class is not to be used. It is marked for deletion. - */ -@Deprecated -public abstract class BaseFragment extends Fragment implements Event.AutoListener { - - public App app = App.self; - protected Unbinder unbinder = null; - - @Override - public void onResume() { - super.onResume(); - Event.register(this); - } - - @Override - public void onPause() { - Event.unregister(this); - super.onPause(); - } - - @Override - public void onDestroyView() { - super.onDestroyView(); - if (unbinder != null) - unbinder.unbind(); - } - - @Override - public void startActivityForResult(Intent intent, int requestCode) { - startActivityForResult(intent, requestCode, (resultCode, data) -> - onActivityResult(requestCode, resultCode, data)); - } - - public void startActivityForResult(Intent intent, int requestCode, - BaseActivity.ActivityResultListener listener) { - ((IBaseLeanback) requireActivity()).startActivityForResult(intent, requestCode, listener); - } - - protected void runWithExternalRW(Runnable callback) { - ((IBaseLeanback) requireActivity()).runWithExternalRW(callback); - } - - @Override - public int[] getListeningEvents() { - return BaseActivity.EMPTY_INT_ARRAY; - } - - @Override - public void onEvent(int event) {} -} diff --git a/app/src/main/java/com/topjohnwu/magisk/ui/base/BasePreferenceFragment.java b/app/src/main/java/com/topjohnwu/magisk/ui/base/BasePreferenceFragment.java index 89e072b26..8ae2bb7a1 100644 --- a/app/src/main/java/com/topjohnwu/magisk/ui/base/BasePreferenceFragment.java +++ b/app/src/main/java/com/topjohnwu/magisk/ui/base/BasePreferenceFragment.java @@ -42,7 +42,7 @@ public abstract class BasePreferenceFragment extends PreferenceFragmentCompat @Override public int[] getListeningEvents() { - return BaseActivity.EMPTY_INT_ARRAY; + return new int[0]; } @Override diff --git a/app/src/main/java/com/topjohnwu/magisk/ui/base/IBaseLeanback.kt b/app/src/main/java/com/topjohnwu/magisk/ui/base/IBaseLeanback.kt index 2a1a7ba14..8008284a4 100644 --- a/app/src/main/java/com/topjohnwu/magisk/ui/base/IBaseLeanback.kt +++ b/app/src/main/java/com/topjohnwu/magisk/ui/base/IBaseLeanback.kt @@ -6,10 +6,6 @@ interface IBaseLeanback { fun runWithExternalRW(callback: Runnable) fun runWithPermissions(vararg permissions: String, callback: Runnable) - fun startActivityForResult( - intent: Intent, - requestCode: Int, - listener: BaseActivity.ActivityResultListener - ) + fun startActivityForResult(intent: Intent, requestCode: Int, listener: ActivityResultListener) } \ No newline at end of file diff --git a/app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskLeanbackActivity.kt b/app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskLeanbackActivity.kt index 365785e42..faaec67f5 100644 --- a/app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskLeanbackActivity.kt +++ b/app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskLeanbackActivity.kt @@ -15,7 +15,7 @@ import com.topjohnwu.magisk.Const abstract class MagiskLeanbackActivity : TeanityActivity(), IBaseLeanback { - private val resultListeners = SparseArrayCompat() + private val resultListeners = SparseArrayCompat() @Deprecated("Permissions will be checked in a different streamlined way") fun runWithExternalRW(callback: () -> Unit) = runWithExternalRW(Runnable { callback() }) @@ -56,7 +56,7 @@ abstract class MagiskLeanbackActivity