MarcoBuster/Magisk
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed menu inflating unnecessarily on every click

Browse Source
This commit is contained in:
Viktor De Pasquale 2020-02-01 14:51:20 +01:00 committed by John Wu
parent dd9129017f
commit f8bea66313
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/src/main/java/com/topjohnwu/magisk/utils/DataBindingAdapters.kt
View File

@ -470,18 +470,19 @@ interface OnPopupMenuItemClickListener {
@BindingAdapter("popupMenu", "popupMenuOnClickListener", requireAll = false) @BindingAdapter("popupMenu", "popupMenuOnClickListener", requireAll = false)
fun View.setPopupMenu(popupMenu: Int, listener: OnPopupMenuItemClickListener) { fun View.setPopupMenu(popupMenu: Int, listener: OnPopupMenuItemClickListener) {
tag = tag as? PopupMenu ?: let { val menu = tag as? PopupMenu ?: let {
val themeWrapper = ContextThemeWrapper(context, R.style.Foundation_PopupMenu) val themeWrapper = ContextThemeWrapper(context, R.style.Foundation_PopupMenu)
PopupMenu(themeWrapper, this) PopupMenu(themeWrapper, this)
} }
setOnClickListener { tag = menu.apply {
(tag as PopupMenu).apply { this.menu.clear()
menuInflater.inflate(popupMenu, menu) menuInflater.inflate(popupMenu, this.menu)
setOnMenuItemClickListener { setOnMenuItemClickListener {
listener.onMenuItemClick(it.itemId) listener.onMenuItemClick(it.itemId)
true true
} }
show()
} }
setOnClickListener {
(tag as PopupMenu).show()
} }
} }