MarcoBuster/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-01-02 16:35:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add todo for checking permissions

Browse Source
This commit is contained in:
Lunny Xiao 2024-11-25 21:48:51 -08:00
parent 71ff661faa
commit 024e2fce51
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
routers/web/repo/pull_review.go
View File

@ -398,6 +398,7 @@ func UpdatePullReviewRequest(ctx *context.Context) {
return return
} }
// TODO: Team review request should check if the team has permission to review the PR
_, err = pull_service.TeamReviewRequest(ctx, issue.PullRequest, ctx.Doer, team, action == "attach") _, err = pull_service.TeamReviewRequest(ctx, issue.PullRequest, ctx.Doer, team, action == "attach")
if err != nil { if err != nil {
if issues_model.IsErrNotValidReviewRequest(err) { if issues_model.IsErrNotValidReviewRequest(err) {
@ -430,6 +431,7 @@ func UpdatePullReviewRequest(ctx *context.Context) {
return return
} }
// TODO: Reviewer review request should check if the user has permission to review the PR
_, err = pull_service.ReviewRequest(ctx, issue.PullRequest, ctx.Doer, &ctx.Repo.Permission, reviewer, action == "attach") _, err = pull_service.ReviewRequest(ctx, issue.PullRequest, ctx.Doer, &ctx.Repo.Permission, reviewer, action == "attach")
if err != nil { if err != nil {
if issues_model.IsErrNotValidReviewRequest(err) { if issues_model.IsErrNotValidReviewRequest(err) {