test with closed state

This commit is contained in:
Zettat123 2024-04-30 15:08:41 +08:00
parent e9436f0b10
commit 0538400d22

View File

@ -591,10 +591,6 @@ func TestPullDontRetargetChildOnWrongRepo(t *testing.T) {
func TestPullMergeIndexerNotifier(t *testing.T) { func TestPullMergeIndexerNotifier(t *testing.T) {
onGiteaRun(t, func(t *testing.T, giteaURL *url.URL) { onGiteaRun(t, func(t *testing.T, giteaURL *url.URL) {
hookTasks, err := webhook.HookTasks(db.DefaultContext, 1, 1) // Retrieve previous hook number
assert.NoError(t, err)
hookTasksLenBefore := len(hookTasks)
// create a pull request // create a pull request
session := loginUser(t, "user1") session := loginUser(t, "user1")
testRepoFork(t, session, "user2", "repo1", "user1", "repo1") testRepoFork(t, session, "user2", "repo1", "user1", "repo1")
@ -617,17 +613,14 @@ func TestPullMergeIndexerNotifier(t *testing.T) {
// search issues // search issues
link, _ := url.Parse("/api/v1/repos/issues/search") link, _ := url.Parse("/api/v1/repos/issues/search")
query := url.Values{} query := url.Values{}
query.Set("state", "open") query.Add("state", "closed")
query.Set("type", "pulls") query.Add("type", "pulls")
query.Set("q", "notifier") query.Add("q", "notifier")
link.RawQuery = query.Encode() link.RawQuery = query.Encode()
searchIssueReq := NewRequest(t, "GET", link.String()) searchIssuesResp := session.MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)
searchIssuesResp := session.MakeRequest(t, searchIssueReq, http.StatusOK)
var apiIssuesBefore []*api.Issue var apiIssuesBefore []*api.Issue
DecodeJSON(t, searchIssuesResp, &apiIssuesBefore) DecodeJSON(t, searchIssuesResp, &apiIssuesBefore)
if assert.Len(t, apiIssuesBefore, 1) { assert.Len(t, apiIssuesBefore, 0)
assert.Equal(t, issue.ID, apiIssuesBefore[0].ID)
}
// merge the pull request // merge the pull request
elem := strings.Split(test.RedirectURL(createPullResp), "/") elem := strings.Split(test.RedirectURL(createPullResp), "/")
@ -643,13 +636,11 @@ func TestPullMergeIndexerNotifier(t *testing.T) {
queue.GetManager().FlushAll(context.Background(), 0) queue.GetManager().FlushAll(context.Background(), 0)
// search issues again // search issues again
searchIssuesResp = session.MakeRequest(t, searchIssueReq, http.StatusOK) searchIssuesResp = session.MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)
var apiIssuesAfter []*api.Issue var apiIssuesAfter []*api.Issue
DecodeJSON(t, searchIssuesResp, &apiIssuesAfter) DecodeJSON(t, searchIssuesResp, &apiIssuesAfter)
assert.Len(t, apiIssuesAfter, 0) if assert.Len(t, apiIssuesAfter, 1) {
assert.Equal(t, issue.ID, apiIssuesAfter[0].ID)
hookTasks, err = webhook.HookTasks(db.DefaultContext, 1, 1) }
assert.NoError(t, err)
assert.Len(t, hookTasks, hookTasksLenBefore+1)
}) })
} }