From 45ebcb0d1c7155dc391f8cfdbf9d7b741fd6e20b Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Wed, 15 Sep 2021 19:30:19 +0800 Subject: [PATCH] Fix bug of migrate comments which only fetch one page (#17055) * Fix bug of migrate comments which only fetch one page * add next page to trace Co-authored-by: zeripath --- modules/migrations/github.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/modules/migrations/github.go b/modules/migrations/github.go index 54af10d116a..97e1b672acc 100644 --- a/modules/migrations/github.go +++ b/modules/migrations/github.go @@ -521,6 +521,9 @@ func (g *GithubDownloaderV3) GetAllComments(page, perPage int) ([]*base.Comment, created = "created" asc = "asc" ) + if perPage > g.maxPerPage { + perPage = g.maxPerPage + } opt := &github.IssueListCommentsOptions{ Sort: &created, Direction: &asc, @@ -535,7 +538,9 @@ func (g *GithubDownloaderV3) GetAllComments(page, perPage int) ([]*base.Comment, if err != nil { return nil, false, fmt.Errorf("error while listing repos: %v", err) } - log.Trace("Request get comments %d/%d, but in fact get %d", perPage, page, len(comments)) + var isEnd = resp.NextPage == 0 + + log.Trace("Request get comments %d/%d, but in fact get %d, next page is %d", perPage, page, len(comments), resp.NextPage) g.rate = &resp.Rate for _, comment := range comments { // get reactions @@ -575,7 +580,7 @@ func (g *GithubDownloaderV3) GetAllComments(page, perPage int) ([]*base.Comment, }) } - return allComments, len(allComments) < perPage, nil + return allComments, isEnd, nil } // GetPullRequests returns pull requests according page and perPage