Avoid 0 new commits messages to be send (#11082)

Fixes #10498
This commit is contained in:
Cornel 2020-04-18 23:02:59 +03:00 committed by GitHub
parent 4f597b1866
commit 6034f8bcaa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -249,12 +249,12 @@ func CommitRepoAction(optsList ...*CommitRepoActionOptions) error {
IsPrivate: repo.IsPrivate, IsPrivate: repo.IsPrivate,
} }
var isHookEventPush = true
switch opType { switch opType {
case models.ActionCommitRepo: // Push case models.ActionCommitRepo: // Push
if opts.IsNewBranch() { if opts.IsNewBranch() {
notification.NotifyCreateRef(pusher, repo, "branch", opts.RefFullName) notification.NotifyCreateRef(pusher, repo, "branch", opts.RefFullName)
} }
notification.NotifyPushCommits(pusher, repo, opts.RefFullName, opts.OldCommitID, opts.NewCommitID, opts.Commits)
case models.ActionDeleteBranch: // Delete Branch case models.ActionDeleteBranch: // Delete Branch
notification.NotifyDeleteRef(pusher, repo, "branch", opts.RefFullName) notification.NotifyDeleteRef(pusher, repo, "branch", opts.RefFullName)
@ -263,12 +263,6 @@ func CommitRepoAction(optsList ...*CommitRepoActionOptions) error {
case models.ActionDeleteTag: // Delete Tag case models.ActionDeleteTag: // Delete Tag
notification.NotifyDeleteRef(pusher, repo, "tag", opts.RefFullName) notification.NotifyDeleteRef(pusher, repo, "tag", opts.RefFullName)
default:
isHookEventPush = false
}
if isHookEventPush {
notification.NotifyPushCommits(pusher, repo, opts.RefFullName, opts.OldCommitID, opts.NewCommitID, opts.Commits)
} }
} }