Fix: don't delete repo when sync failed

This commit is contained in:
harryzcy 2023-05-06 21:24:06 -04:00
parent a3a40157a3
commit b8f8ab43a6
No known key found for this signature in database
GPG Key ID: E3C2287691E40E35
1 changed files with 5 additions and 5 deletions

View File

@ -507,11 +507,11 @@ func SyncRepository(ctx context.Context, doer *user_model.User, repo *repo_model
}
if err := syncRepository(downloader, uploader, opts, messenger, lastSynced); err != nil {
if err1 := uploader.Rollback(); err1 != nil {
log.Error("rollback failed: %v", err1)
}
if err2 := system_model.CreateRepositoryNotice(fmt.Sprintf("Syncing repository from %s failed: %v", opts.OriginalURL, err)); err2 != nil {
log.Error("create repository notice failed: ", err2)
// It's different from migration that we shouldn't rollback here,
// because the only thing rollback does is to delete the repository
if err := system_model.CreateRepositoryNotice(fmt.Sprintf("Syncing repository from %s failed: %v", opts.OriginalURL, err)); err != nil {
log.Error("create repository notice failed: ", err)
}
return nil, err
}