From cabcca3d818e1c7fdfd4ddf41e233f273b779481 Mon Sep 17 00:00:00 2001 From: Jason Song Date: Fri, 26 Jul 2024 07:26:41 +0800 Subject: [PATCH] Run `detectWebAuthnSupport` only if necessary (#31691) Follow #31676, which is not correct, see https://github.com/go-gitea/gitea/pull/31676#issuecomment-2246658217 Fix #31675, regression of #31504. --- web_src/js/features/user-auth-webauthn.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web_src/js/features/user-auth-webauthn.ts b/web_src/js/features/user-auth-webauthn.ts index 35c6aa8f7c..610b559833 100644 --- a/web_src/js/features/user-auth-webauthn.ts +++ b/web_src/js/features/user-auth-webauthn.ts @@ -5,7 +5,9 @@ import {GET, POST} from '../modules/fetch.ts'; const {appSubUrl} = window.config; export async function initUserAuthWebAuthn() { - if (!document.querySelector('.user.signin')) { + const elPrompt = document.querySelector('.user.signin.webauthn-prompt'); + const elSignInPasskeyBtn = document.querySelector('.signin-passkey'); + if (!elPrompt && !elSignInPasskeyBtn) { return; } @@ -13,12 +15,10 @@ export async function initUserAuthWebAuthn() { return; } - const elSignInPasskeyBtn = document.querySelector('.signin-passkey'); if (elSignInPasskeyBtn) { elSignInPasskeyBtn.addEventListener('click', loginPasskey); } - const elPrompt = document.querySelector('.user.signin.webauthn-prompt'); if (elPrompt) { login2FA(); }