chore: fix the extra comment icon at the end and change the icon pointer

This commit is contained in:
Rajesh Jonnalagadda 2024-11-28 04:27:47 +05:30
parent 7d0c8e30e0
commit ea285c2131
6 changed files with 10 additions and 6 deletions

View File

@ -957,7 +957,7 @@ func ExcerptBlob(ctx *context.Context) {
} }
lineCommits := allComments[filePath] lineCommits := allComments[filePath]
for _, line := range section.Lines { for _, line := range section.Lines {
if line.SectionInfo != nil { if line.SectionInfo != nil && line.SectionInfo.RightHunkSize > 0 {
start := int64(line.SectionInfo.LastRightIdx + 1) start := int64(line.SectionInfo.LastRightIdx + 1)
end := int64(line.SectionInfo.RightIdx - 1) end := int64(line.SectionInfo.RightIdx - 1)
for start <= end { for start <= end {

View File

@ -482,7 +482,7 @@ func (diff *Diff) LoadComments(ctx context.Context, issue *issues_model.Issue, c
if lineCommits, ok := allComments[file.Name]; ok { if lineCommits, ok := allComments[file.Name]; ok {
for _, section := range file.Sections { for _, section := range file.Sections {
for _, line := range section.Lines { for _, line := range section.Lines {
if line.SectionInfo != nil { if line.SectionInfo != nil && line.SectionInfo.RightHunkSize > 0 {
start := int64(line.SectionInfo.LastRightIdx + 1) start := int64(line.SectionInfo.LastRightIdx + 1)
end := int64(line.SectionInfo.RightIdx - 1) end := int64(line.SectionInfo.RightIdx - 1)
for start <= end { for start <= end {

View File

@ -8,7 +8,7 @@
<div class="lines-comment"> <div class="lines-comment">
<div> <div>
{{if $line.SectionInfo.HasComments}} {{if $line.SectionInfo.HasComments}}
<button> <button class="section-comment-icon">
{{svg "octicon-comment-discussion"}} {{svg "octicon-comment-discussion"}}
</button> </button>
{{end}} {{end}}
@ -81,7 +81,7 @@
<div class="lines-comment"> <div class="lines-comment">
<div> <div>
{{if $line.SectionInfo.HasComments}} {{if $line.SectionInfo.HasComments}}
<button> <button class="section-comment-icon">
{{svg "octicon-comment-discussion"}} {{svg "octicon-comment-discussion"}}
</button> </button>
{{end}} {{end}}

View File

@ -22,7 +22,7 @@
<div class="lines-comment"> <div class="lines-comment">
<div> <div>
{{if $line.SectionInfo.HasComments}} {{if $line.SectionInfo.HasComments}}
<button> <button class="section-comment-icon">
{{svg "octicon-comment-discussion"}} {{svg "octicon-comment-discussion"}}
</button> </button>
{{end}} {{end}}

View File

@ -18,7 +18,7 @@
<div class="lines-comment"> <div class="lines-comment">
<div> <div>
{{if $line.SectionInfo.HasComments}} {{if $line.SectionInfo.HasComments}}
<button> <button class="section-comment-icon">
{{svg "octicon-comment-discussion"}} {{svg "octicon-comment-discussion"}}
</button> </button>
{{end}} {{end}}

View File

@ -1148,6 +1148,10 @@ overflow-menu .ui.label {
gap: 1px; gap: 1px;
} }
.section-comment-icon {
cursor: default;
}
.lines-commit .blame-info .blame-data .blame-message { .lines-commit .blame-info .blame-data .blame-message {
flex-grow: 2; flex-grow: 2;
overflow: hidden; overflow: hidden;