zeripath
596eebb2b6
Protect against NPEs in notifications list ( #10879 ) ( #10883 )
...
* Protect against NPEs in notifications list (#10879 )
Unfortunately there appears to be potential race with notifications
being set before the associated issue has been committed.
This PR adds protection in to the notifications list to log any failures
and remove these notifications from the display.
References #10815 - and prevents the panic but does not completely fix
this.
Signed-off-by: Andrew Thornton <art27@cantab.net>
* add log import
* Update models/notification.go
Co-Authored-By: Lauris BH <lauris@nix.lv>
Co-authored-by: Lauris BH <lauris@nix.lv>
2020-03-30 15:23:02 +08:00
Lunny Xiao
bb6879d339
Improve notification ( #8835 )
...
* Improve notifications
* batch load user
* Update notification only when read
* Fix reorder
* fix lint
* fix test
* fix lint
* make function meaningful
* fix comment
2019-11-12 16:33:34 +08:00
Mario Lubenka
fcbac38d6f
Unifies pagination template usage ( #6531 ) ( #6533 )
2019-04-20 00:15:19 -04:00
Morgan Bazalgette
65861900cd
Handle refactor ( #3339 )
...
* Replace all ctx.Handle with ctx.ServerError or ctx.NotFound
* Change Handle(403) to NotFound, avoid using macaron's NotFound
2018-01-10 23:34:17 +02:00
Sasha Varlamov
7ec6cddd27
Add 'mark all read' option to notifications ( #3097 )
...
* Add 'mark all read' option to notifications
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
* Fix exported comment
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
* Format method comments
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
* Fix exported comment
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
Format method comments
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
Tests for reactions (#3083 )
* Unit tests for reactions
* Fix import order
Signed-off-by: Lauris Bukšis-Haberkorns <lauris@nix.lv>
Fix reaction possition when there is attachments (#3099 )
Refactor notifications swap function
* Accept change to drop beforeupdate call
* Update purge notifications error message for consistency
* Drop unnecessary check for mark all as read button
* Remove debugging comment
2017-12-07 13:52:57 +08:00
Bo-Yi Wu
3576e1ee73
fix: trim the whitespaces for the search keyword ( #893 )
2017-02-11 12:00:01 +08:00
Ethan Koenig
2eb15f4a61
Unit tests and remove unused functions in models/notification ( #796 )
...
* Unit tests and remove unused functions in models/notification
* Read -> Unread
2017-01-30 22:21:49 +08:00
Andrey Nering
d2bb8ef503
Notifications: trying to get a better layout ( #660 )
...
* i18n button titles
* Improvements on notification page layout
* Notification count badge fixes
* Make table <tr> clickable
* Fix octicon aligment
* Fix use of AppSubUrl
2017-01-18 09:18:55 +08:00
xgitea
64b167138f
docs: update translation on notification page for zh-CN ( #649 )
...
* docs: update translation on notification page for zh-CN
* use international resources
2017-01-13 17:31:48 +08:00
Andrey Nering
769e0a3ea6
Notifications: mark as read/unread and pin ( #629 )
...
* Use relative URLs
* Notifications - Mark as read/unread
* Feature of pinning a notification
* On view issue, do not mark as read a pinned notification
2017-01-12 12:27:09 +08:00
Andrey Nering
b354cf362e
Add pagination for notifications
2017-01-03 17:09:36 -02:00
Andrey Nering
341a3b571b
Do not get count on /api routers
2017-01-02 16:31:50 -02:00
Andrey Nering
6069abe5fd
Notifications - Step 2
2016-12-30 16:51:24 -02:00
