mirror of
https://github.com/go-gitea/gitea
synced 2024-12-22 16:17:55 +01:00
027014d7de
Follow: * #22697 There are some bugs in #22697: * https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966 * the webauthn failure message is never shown and causes console error * The `document.getElementById('register-button')` and `document.getElementById('login-button')` is wrong * there is no such element in code * it causes JS error when a browser doesn't provide webauthn * the end user can't see the real error message These bugs are fixed in this PR. Other changes: * Use simple HTML/CSS layouts, no need to use too many `gt-` patches * Make the webauthn page have correct "page-content" layout * The "data-webauthn-error-msg" elements are only used to provide locale texts, so move them into a single "gt-hidden", then no need to repeat a lot of "gt-hidden" in code * The `{{.CsrfTokenHtml}}` is a no-op because there is no form * Many `hideElem('#webauthn-error')` in code is no-op because the `webauthn-error` already has "gt-hidden" by default * Make the tests for "URLEncodedBase64" really test with concrete cases. Screenshots: * Error message when webauthn fails (before, there is no error message): <details>  </details> * Error message when webauthn is unavailable <details>  </details> |
||
|---|---|---|
| .. | ||
| activate.tmpl | ||
| captcha.tmpl | ||
| change_passwd_inner.tmpl | ||
| change_passwd.tmpl | ||
| finalize_openid.tmpl | ||
| forgot_passwd.tmpl | ||
| grant_error.tmpl | ||
| grant.tmpl | ||
| link_account.tmpl | ||
| oidc_wellknown.tmpl | ||
| prohibit_login.tmpl | ||
| reset_passwd.tmpl | ||
| signin_inner.tmpl | ||
| signin_navbar.tmpl | ||
| signin_openid.tmpl | ||
| signin.tmpl | ||
| signup_inner.tmpl | ||
| signup_openid_connect.tmpl | ||
| signup_openid_navbar.tmpl | ||
| signup_openid_register.tmpl | ||
| signup.tmpl | ||
| twofa_scratch.tmpl | ||
| twofa.tmpl | ||
| webauthn_error.tmpl | ||
| webauthn.tmpl | ||