gitea/templates/repo
delvh 81fe5d6185
Convert <div class="button"> to <button class="button"> (#23337)
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-03-14 11:34:09 +08:00
..
actions Fix actions frontend bugs (pagination, long name alignment) and small simplify (#23370) 2023-03-13 13:31:06 +08:00
branch Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
cite Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
diff Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
editor Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
find Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
graph Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
issue Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
migrate Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
projects Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
pulls Always go full width in PR view (#22844) 2023-02-16 13:25:00 -06:00
release Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
settings Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
wiki Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
activity.tmpl Add context when rendering labels or emojis (#23281) 2023-03-05 22:59:05 +01:00
blame.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
branch_dropdown.tmpl Refactor branch/tag selector dropdown (first step) (#23394) 2023-03-11 12:47:09 +02:00
clone_buttons.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
clone_script.tmpl Make clone URL use current page's host (#22808) 2023-02-09 17:29:13 +08:00
commit_page.tmpl Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
commit_status.tmpl Fix missing commit status in PR which from forked repo (#23351) 2023-03-13 16:05:19 -05:00
commit_statuses.tmpl Fix hidden commit status on multiple checks (#22889) 2023-02-20 16:43:04 +08:00
commits_list_small.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
commits_list.tmpl Add context when rendering labels or emojis (#23281) 2023-03-05 22:59:05 +01:00
commits_table.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
commits.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
create_helper.tmpl Add templates to customize text when creating and migrating repositories 2023-01-24 22:36:48 -05:00
create.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
empty.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
file_info.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
forks.tmpl Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
graph.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
header.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
home.tmpl Fix and move "Use this template" button (#23398) 2023-03-09 22:14:45 -05:00
icon.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
packages.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
search.tmpl Remove Fomantic-UI's .hidden CSS class for menu elements (#22895) 2023-02-14 19:53:54 +08:00
shabox_badge.tmpl Fix shabox regression (#22924) 2023-02-16 09:37:11 +08:00
sub_menu.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
unicode_escape_prompt.tmpl Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
upload.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
user_cards.tmpl Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
view_file.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
view_list.tmpl Add wrapper to author to avoid long name ui problem (#23030) 2023-02-23 14:28:18 -06:00
watchers.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00