delvh
81fe5d6185
Convert <div class="button"> to <button class="button"> ( #23337 ) ...
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice
Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.
## Future improvements
As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391 ,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-03-14 11:34:09 +08:00
2021-05-22 23:29:46 +02:00
2023-03-14 11:34:09 +08:00
2022-08-10 18:30:40 +02:00
2021-05-22 23:29:46 +02:00
2023-02-05 18:12:31 +08:00
2023-02-06 09:49:21 +08:00
2022-10-28 09:40:50 -04:00
2022-10-28 09:40:50 -04:00
2022-10-28 09:40:50 -04:00
2023-02-01 12:30:39 -06:00
2021-03-22 05:04:19 +01:00
2021-03-22 05:04:19 +01:00
2022-08-12 13:51:33 -04:00
2021-09-18 17:22:51 +01:00
2021-11-16 12:24:22 +08:00
2022-10-28 09:40:50 -04:00
2021-09-09 08:06:54 +01:00
2021-03-22 05:04:19 +01:00
2022-10-28 09:40:50 -04:00
2022-10-28 09:40:50 -04:00
2022-08-26 18:49:40 +02:00
2022-10-28 09:40:50 -04:00
2021-03-22 05:04:19 +01:00
2022-11-21 20:25:26 +00:00
2022-10-28 09:40:50 -04:00
2022-10-28 09:40:50 -04:00
2022-10-28 09:40:50 -04:00
2021-08-22 00:47:45 +02:00
2022-10-28 09:40:50 -04:00
2022-10-28 09:40:50 -04:00
2022-10-28 09:40:50 -04:00
2022-08-26 18:49:40 +02:00
2023-03-13 15:28:39 -05:00
2021-03-22 05:04:19 +01:00
2022-08-29 15:04:45 +08:00
2021-11-14 16:48:26 -05:00
2022-08-26 18:49:40 +02:00
2020-08-06 09:04:08 +01:00
2020-08-06 09:04:08 +01:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
2023-01-21 10:42:13 +08:00
81fe5d6185
