mirror of
https://github.com/go-gitea/gitea
synced 2024-10-31 16:53:25 +01:00
5d2e11eedb
`models` does far too much. In particular it handles all `UserSignin`. It shouldn't be responsible for calling LDAP, SMTP or PAM for signing in. Therefore we should move this code out of `models`. This code has to depend on `models` - therefore it belongs in `services`. There is a package in `services` called `auth` and clearly this functionality belongs in there. Plan: - [x] Change `auth.Auth` to `auth.Method` - as they represent methods of authentication. - [x] Move `models.UserSignIn` into `auth` - [x] Move `models.ExternalUserLogin` - [x] Move most of the `LoginVia*` methods to `auth` or subpackages - [x] Move Resynchronize functionality to `auth` - Involved some restructuring of `models/ssh_key.go` to reduce the size of this massive file and simplify its files. - [x] Move the rest of the LDAP functionality in to the ldap subpackage - [x] Re-factor the login sources to express an interfaces `auth.Source`? - I've done this through some smaller interfaces Authenticator and Synchronizable - which would allow us to extend things in future - [x] Now LDAP is out of models - need to think about modules/auth/ldap and I think all of that functionality might just be moveable - [x] Similarly a lot Oauth2 functionality need not be in models too and should be moved to services/auth/source/oauth2 - [x] modules/auth/oauth2/oauth2.go uses xorm... This is naughty - probably need to move this into models. - [x] models/oauth2.go - mostly should be in modules/auth/oauth2 or services/auth/source/oauth2 - [x] More simplifications of login_source.go may need to be done - Allow wiring in of notify registration - *this can now easily be done - but I think we should do it in another PR* - see #16178 - More refactors...? - OpenID should probably become an auth Method but I think that can be left for another PR - Methods should also probably be cleaned up - again another PR I think. - SSPI still needs more refactors.* Rename auth.Auth auth.Method * Restructure ssh_key.go - move functions from models/user.go that relate to ssh_key to ssh_key - split ssh_key.go to try create clearer function domains for allow for future refactors here. Signed-off-by: Andrew Thornton <art27@cantab.net>
49 lines
1.1 KiB
YAML
49 lines
1.1 KiB
YAML
# type LoginSource struct {
|
|
# ID int64 `xorm:"pk autoincr"`
|
|
# Type int
|
|
# Cfg []byte `xorm:"TEXT"`
|
|
# Expected []byte `xorm:"TEXT"`
|
|
# }
|
|
-
|
|
id: 1
|
|
type: 1
|
|
is_actived: false
|
|
cfg: "{\"Source\":{\"A\":\"string\",\"B\":1}}"
|
|
expected: "{\"Source\":{\"A\":\"string\",\"B\":1}}"
|
|
-
|
|
id: 2
|
|
type: 2
|
|
is_actived: true
|
|
cfg: "{\"Source\":{\"A\":\"string2\",\"B\":2}}"
|
|
expected: "{\"A\":\"string2\",\"B\":2}"
|
|
-
|
|
id: 3
|
|
type: 3
|
|
is_actived: false
|
|
cfg: "{\"Source\":{\"A\":\"string3\",\"B\":3}}"
|
|
expected: "{\"Source\":{\"A\":\"string3\",\"B\":3}}"
|
|
-
|
|
id: 4
|
|
type: 4
|
|
is_actived: true
|
|
cfg: "{\"Source\":{\"A\":\"string4\",\"B\":4}}"
|
|
expected: "{\"Source\":{\"A\":\"string4\",\"B\":4}}"
|
|
-
|
|
id: 5
|
|
type: 5
|
|
is_actived: false
|
|
cfg: "{\"Source\":{\"A\":\"string5\",\"B\":5}}"
|
|
expected: "{\"A\":\"string5\",\"B\":5}"
|
|
-
|
|
id: 6
|
|
type: 2
|
|
is_actived: true
|
|
cfg: "{\"A\":\"string6\",\"B\":6}"
|
|
expected: "{\"A\":\"string6\",\"B\":6}"
|
|
-
|
|
id: 7
|
|
type: 5
|
|
is_actived: false
|
|
cfg: "{\"A\":\"string7\",\"B\":7}"
|
|
expected: "{\"A\":\"string7\",\"B\":7}"
|