mirror of
https://github.com/go-gitea/gitea
synced 2024-12-23 23:56:00 +01:00
18f26cfbf7
Before there was a "graceful function": RunWithShutdownFns, it's mainly for some modules which doesn't support context. The old queue system doesn't work well with context, so the old queues need it. After the queue refactoring, the new queue works with context well, so, use Golang context as much as possible, the `RunWithShutdownFns` could be removed (replaced by RunWithCancel for context cancel mechanism), the related code could be simplified. This PR also fixes some legacy queue-init problems, eg: * typo : archiver: "unable to create codes indexer queue" => "unable to create repo-archive queue" * no nil check for failed queues, which causes unfriendly panic After this PR, many goroutines could have better display name: ![image](https://github.com/go-gitea/gitea/assets/2114189/701b2a9b-8065-4137-aeaa-0bda2b34604a) ![image](https://github.com/go-gitea/gitea/assets/2114189/f1d5f50f-0534-40f0-b0be-f2c9daa5fe92)
50 lines
1.3 KiB
Go
50 lines
1.3 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package stats
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/modules/graceful"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/queue"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
)
|
|
|
|
// statsQueue represents a queue to handle repository stats updates
|
|
var statsQueue *queue.WorkerPoolQueue[int64]
|
|
|
|
// handle passed PR IDs and test the PRs
|
|
func handler(items ...int64) []int64 {
|
|
for _, opts := range items {
|
|
if err := indexer.Index(opts); err != nil {
|
|
if !setting.IsInTesting {
|
|
log.Error("stats queue indexer.Index(%d) failed: %v", opts, err)
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func initStatsQueue() error {
|
|
statsQueue = queue.CreateUniqueQueue(graceful.GetManager().ShutdownContext(), "repo_stats_update", handler)
|
|
if statsQueue == nil {
|
|
return fmt.Errorf("unable to create repo_stats_update queue")
|
|
}
|
|
go graceful.GetManager().RunWithCancel(statsQueue)
|
|
return nil
|
|
}
|
|
|
|
// UpdateRepoIndexer update a repository's entries in the indexer
|
|
func UpdateRepoIndexer(repo *repo_model.Repository) error {
|
|
if err := statsQueue.Push(repo.ID); err != nil {
|
|
if err != queue.ErrAlreadyInQueue {
|
|
return err
|
|
}
|
|
log.Debug("Repo ID: %d already queued", repo.ID)
|
|
}
|
|
return nil
|
|
}
|