mirror of
https://github.com/go-gitea/gitea
synced 2024-08-27 01:32:53 +02:00
Changes in this PR : Strips incoming request URL of additional slashes (/). For example an input like `https://git.data.coop//halfd/new-website.git` is translated to `https://git.data.coop/halfd/new-website.git` Fixes https://github.com/go-gitea/gitea/issues/20462 Fix #23242 --------- Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
71 lines
1.8 KiB
Go
71 lines
1.8 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
package common
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestStripSlashesMiddleware(t *testing.T) {
|
|
type test struct {
|
|
name string
|
|
expectedPath string
|
|
inputPath string
|
|
}
|
|
|
|
tests := []test{
|
|
{
|
|
name: "path with multiple slashes",
|
|
inputPath: "https://github.com///go-gitea//gitea.git",
|
|
expectedPath: "/go-gitea/gitea.git",
|
|
},
|
|
{
|
|
name: "path with no slashes",
|
|
inputPath: "https://github.com/go-gitea/gitea.git",
|
|
expectedPath: "/go-gitea/gitea.git",
|
|
},
|
|
{
|
|
name: "path with slashes in the middle",
|
|
inputPath: "https://git.data.coop//halfd/new-website.git",
|
|
expectedPath: "/halfd/new-website.git",
|
|
},
|
|
{
|
|
name: "path with slashes in the middle",
|
|
inputPath: "https://git.data.coop//halfd/new-website.git",
|
|
expectedPath: "/halfd/new-website.git",
|
|
},
|
|
{
|
|
name: "path with slashes in the end",
|
|
inputPath: "/user2//repo1/",
|
|
expectedPath: "/user2/repo1",
|
|
},
|
|
{
|
|
name: "path with slashes and query params",
|
|
inputPath: "/repo//migrate?service_type=3",
|
|
expectedPath: "/repo/migrate",
|
|
},
|
|
{
|
|
name: "path with encoded slash",
|
|
inputPath: "/user2/%2F%2Frepo1",
|
|
expectedPath: "/user2/%2F%2Frepo1",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
testMiddleware := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
assert.Equal(t, tt.expectedPath, r.URL.Path)
|
|
})
|
|
|
|
// pass the test middleware to validate the changes
|
|
handlerToTest := stripSlashesMiddleware(testMiddleware)
|
|
// create a mock request to use
|
|
req := httptest.NewRequest("GET", tt.inputPath, nil)
|
|
// call the handler using a mock response recorder
|
|
handlerToTest.ServeHTTP(httptest.NewRecorder(), req)
|
|
}
|
|
}
|