mirror of
https://github.com/go-gitea/gitea
synced 2024-12-22 18:28:01 +01:00
d056bf300f
* Clean up ref name rules Clean up checks on reference names to better conform to the guideline here: https://git-scm.com/docs/git-check-ref-format This fixes half of #6321 * Update branch create integration test According to: https://git-scm.com/docs/git-check-ref-format And: git check-ref-format "master/feature=test1" This is a valid branch name and we should not be testing for it to fail.
267 lines
5.8 KiB
Go
267 lines
5.8 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package validation
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/go-macaron/binding"
|
|
)
|
|
|
|
var gitRefNameValidationTestCases = []validationTestCase{
|
|
{
|
|
description: "Referece contains only characters",
|
|
data: TestForm{
|
|
BranchName: "test",
|
|
},
|
|
expectedErrors: binding.Errors{},
|
|
},
|
|
{
|
|
description: "Reference name contains single slash",
|
|
data: TestForm{
|
|
BranchName: "feature/test",
|
|
},
|
|
expectedErrors: binding.Errors{},
|
|
},
|
|
{
|
|
description: "Reference name has allowed special characters",
|
|
data: TestForm{
|
|
BranchName: "debian/1%1.6.0-2",
|
|
},
|
|
expectedErrors: binding.Errors{},
|
|
},
|
|
{
|
|
description: "Reference name contains backslash",
|
|
data: TestForm{
|
|
BranchName: "feature\\test",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name starts with dot",
|
|
data: TestForm{
|
|
BranchName: ".test",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name ends with dot",
|
|
data: TestForm{
|
|
BranchName: "test.",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name starts with slash",
|
|
data: TestForm{
|
|
BranchName: "/test",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name ends with slash",
|
|
data: TestForm{
|
|
BranchName: "test/",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name ends with .lock",
|
|
data: TestForm{
|
|
BranchName: "test.lock",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name contains multiple consecutive dots",
|
|
data: TestForm{
|
|
BranchName: "te..st",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name contains multiple consecutive slashes",
|
|
data: TestForm{
|
|
BranchName: "te//st",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name is single @",
|
|
data: TestForm{
|
|
BranchName: "@",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name has @{",
|
|
data: TestForm{
|
|
BranchName: "branch@{",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name has unallowed special character ~",
|
|
data: TestForm{
|
|
BranchName: "~debian/1%1.6.0-2",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name has unallowed special character *",
|
|
data: TestForm{
|
|
BranchName: "*debian/1%1.6.0-2",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name has unallowed special character ?",
|
|
data: TestForm{
|
|
BranchName: "?debian/1%1.6.0-2",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name has unallowed special character ^",
|
|
data: TestForm{
|
|
BranchName: "^debian/1%1.6.0-2",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name has unallowed special character :",
|
|
data: TestForm{
|
|
BranchName: "debian:jessie",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name has unallowed special character (whitespace)",
|
|
data: TestForm{
|
|
BranchName: "debian jessie",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "Reference name has unallowed special character [",
|
|
data: TestForm{
|
|
BranchName: "debian[jessie",
|
|
},
|
|
expectedErrors: binding.Errors{
|
|
binding.Error{
|
|
FieldNames: []string{"BranchName"},
|
|
Classification: ErrGitRefName,
|
|
Message: "GitRefName",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
func Test_GitRefNameValidation(t *testing.T) {
|
|
AddBindingRules()
|
|
|
|
for _, testCase := range gitRefNameValidationTestCases {
|
|
t.Run(testCase.description, func(t *testing.T) {
|
|
performValidationTest(t, testCase)
|
|
})
|
|
}
|
|
}
|