mirror of
https://github.com/go-gitea/gitea
synced 2024-11-05 14:37:02 +01:00
61b89747ed
This PR refactors and improves the password hashing code within gitea and makes it possible for server administrators to set the password hashing parameters In addition it takes the opportunity to adjust the settings for `pbkdf2` in order to make the hashing a little stronger. The majority of this work was inspired by PR #14751 and I would like to thank @boppy for their work on this. Thanks to @gusted for the suggestion to adjust the `pbkdf2` hashing parameters. Close #14751 --------- Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
481 lines
14 KiB
Go
481 lines
14 KiB
Go
// Copyright 2014 The Gogs Authors. All rights reserved.
|
|
// Copyright 2020 The Gitea Authors.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package admin
|
|
|
|
import (
|
|
"net/http"
|
|
"net/url"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/models/auth"
|
|
"code.gitea.io/gitea/models/db"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/auth/password"
|
|
"code.gitea.io/gitea/modules/base"
|
|
"code.gitea.io/gitea/modules/context"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/util"
|
|
"code.gitea.io/gitea/modules/web"
|
|
"code.gitea.io/gitea/routers/web/explore"
|
|
user_setting "code.gitea.io/gitea/routers/web/user/setting"
|
|
"code.gitea.io/gitea/services/forms"
|
|
"code.gitea.io/gitea/services/mailer"
|
|
user_service "code.gitea.io/gitea/services/user"
|
|
)
|
|
|
|
const (
|
|
tplUsers base.TplName = "admin/user/list"
|
|
tplUserNew base.TplName = "admin/user/new"
|
|
tplUserEdit base.TplName = "admin/user/edit"
|
|
)
|
|
|
|
// Users show all the users
|
|
func Users(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("admin.users")
|
|
ctx.Data["PageIsAdmin"] = true
|
|
ctx.Data["PageIsAdminUsers"] = true
|
|
|
|
extraParamStrings := map[string]string{}
|
|
statusFilterKeys := []string{"is_active", "is_admin", "is_restricted", "is_2fa_enabled", "is_prohibit_login"}
|
|
statusFilterMap := map[string]string{}
|
|
for _, filterKey := range statusFilterKeys {
|
|
paramKey := "status_filter[" + filterKey + "]"
|
|
paramVal := ctx.FormString(paramKey)
|
|
statusFilterMap[filterKey] = paramVal
|
|
if paramVal != "" {
|
|
extraParamStrings[paramKey] = paramVal
|
|
}
|
|
}
|
|
|
|
sortType := ctx.FormString("sort")
|
|
if sortType == "" {
|
|
sortType = explore.UserSearchDefaultSortType
|
|
}
|
|
ctx.PageData["adminUserListSearchForm"] = map[string]interface{}{
|
|
"StatusFilterMap": statusFilterMap,
|
|
"SortType": sortType,
|
|
}
|
|
|
|
explore.RenderUserSearch(ctx, &user_model.SearchUserOptions{
|
|
Actor: ctx.Doer,
|
|
Type: user_model.UserTypeIndividual,
|
|
ListOptions: db.ListOptions{
|
|
PageSize: setting.UI.Admin.UserPagingNum,
|
|
},
|
|
SearchByEmail: true,
|
|
IsActive: util.OptionalBoolParse(statusFilterMap["is_active"]),
|
|
IsAdmin: util.OptionalBoolParse(statusFilterMap["is_admin"]),
|
|
IsRestricted: util.OptionalBoolParse(statusFilterMap["is_restricted"]),
|
|
IsTwoFactorEnabled: util.OptionalBoolParse(statusFilterMap["is_2fa_enabled"]),
|
|
IsProhibitLogin: util.OptionalBoolParse(statusFilterMap["is_prohibit_login"]),
|
|
ExtraParamStrings: extraParamStrings,
|
|
}, tplUsers)
|
|
}
|
|
|
|
// NewUser render adding a new user page
|
|
func NewUser(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("admin.users.new_account")
|
|
ctx.Data["PageIsAdmin"] = true
|
|
ctx.Data["PageIsAdminUsers"] = true
|
|
ctx.Data["DefaultUserVisibilityMode"] = setting.Service.DefaultUserVisibilityMode
|
|
ctx.Data["AllowedUserVisibilityModes"] = setting.Service.AllowedUserVisibilityModesSlice.ToVisibleTypeSlice()
|
|
|
|
ctx.Data["login_type"] = "0-0"
|
|
|
|
sources, err := auth.Sources()
|
|
if err != nil {
|
|
ctx.ServerError("auth.Sources", err)
|
|
return
|
|
}
|
|
ctx.Data["Sources"] = sources
|
|
|
|
ctx.Data["CanSendEmail"] = setting.MailService != nil
|
|
ctx.HTML(http.StatusOK, tplUserNew)
|
|
}
|
|
|
|
// NewUserPost response for adding a new user
|
|
func NewUserPost(ctx *context.Context) {
|
|
form := web.GetForm(ctx).(*forms.AdminCreateUserForm)
|
|
ctx.Data["Title"] = ctx.Tr("admin.users.new_account")
|
|
ctx.Data["PageIsAdmin"] = true
|
|
ctx.Data["PageIsAdminUsers"] = true
|
|
ctx.Data["DefaultUserVisibilityMode"] = setting.Service.DefaultUserVisibilityMode
|
|
|
|
sources, err := auth.Sources()
|
|
if err != nil {
|
|
ctx.ServerError("auth.Sources", err)
|
|
return
|
|
}
|
|
ctx.Data["Sources"] = sources
|
|
|
|
ctx.Data["CanSendEmail"] = setting.MailService != nil
|
|
|
|
if ctx.HasError() {
|
|
ctx.HTML(http.StatusOK, tplUserNew)
|
|
return
|
|
}
|
|
|
|
u := &user_model.User{
|
|
Name: form.UserName,
|
|
Email: form.Email,
|
|
Passwd: form.Password,
|
|
LoginType: auth.Plain,
|
|
}
|
|
|
|
overwriteDefault := &user_model.CreateUserOverwriteOptions{
|
|
IsActive: util.OptionalBoolTrue,
|
|
Visibility: &form.Visibility,
|
|
}
|
|
|
|
if len(form.LoginType) > 0 {
|
|
fields := strings.Split(form.LoginType, "-")
|
|
if len(fields) == 2 {
|
|
lType, _ := strconv.ParseInt(fields[0], 10, 0)
|
|
u.LoginType = auth.Type(lType)
|
|
u.LoginSource, _ = strconv.ParseInt(fields[1], 10, 64)
|
|
u.LoginName = form.LoginName
|
|
}
|
|
}
|
|
if u.LoginType == auth.NoType || u.LoginType == auth.Plain {
|
|
if len(form.Password) < setting.MinPasswordLength {
|
|
ctx.Data["Err_Password"] = true
|
|
ctx.RenderWithErr(ctx.Tr("auth.password_too_short", setting.MinPasswordLength), tplUserNew, &form)
|
|
return
|
|
}
|
|
if !password.IsComplexEnough(form.Password) {
|
|
ctx.Data["Err_Password"] = true
|
|
ctx.RenderWithErr(password.BuildComplexityError(ctx), tplUserNew, &form)
|
|
return
|
|
}
|
|
pwned, err := password.IsPwned(ctx, form.Password)
|
|
if pwned {
|
|
ctx.Data["Err_Password"] = true
|
|
errMsg := ctx.Tr("auth.password_pwned")
|
|
if err != nil {
|
|
log.Error(err.Error())
|
|
errMsg = ctx.Tr("auth.password_pwned_err")
|
|
}
|
|
ctx.RenderWithErr(errMsg, tplUserNew, &form)
|
|
return
|
|
}
|
|
u.MustChangePassword = form.MustChangePassword
|
|
}
|
|
|
|
if err := user_model.CreateUser(u, overwriteDefault); err != nil {
|
|
switch {
|
|
case user_model.IsErrUserAlreadyExist(err):
|
|
ctx.Data["Err_UserName"] = true
|
|
ctx.RenderWithErr(ctx.Tr("form.username_been_taken"), tplUserNew, &form)
|
|
case user_model.IsErrEmailAlreadyUsed(err):
|
|
ctx.Data["Err_Email"] = true
|
|
ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplUserNew, &form)
|
|
case user_model.IsErrEmailCharIsNotSupported(err):
|
|
ctx.Data["Err_Email"] = true
|
|
ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tplUserNew, &form)
|
|
case user_model.IsErrEmailInvalid(err):
|
|
ctx.Data["Err_Email"] = true
|
|
ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tplUserNew, &form)
|
|
case db.IsErrNameReserved(err):
|
|
ctx.Data["Err_UserName"] = true
|
|
ctx.RenderWithErr(ctx.Tr("user.form.name_reserved", err.(db.ErrNameReserved).Name), tplUserNew, &form)
|
|
case db.IsErrNamePatternNotAllowed(err):
|
|
ctx.Data["Err_UserName"] = true
|
|
ctx.RenderWithErr(ctx.Tr("user.form.name_pattern_not_allowed", err.(db.ErrNamePatternNotAllowed).Pattern), tplUserNew, &form)
|
|
case db.IsErrNameCharsNotAllowed(err):
|
|
ctx.Data["Err_UserName"] = true
|
|
ctx.RenderWithErr(ctx.Tr("user.form.name_chars_not_allowed", err.(db.ErrNameCharsNotAllowed).Name), tplUserNew, &form)
|
|
default:
|
|
ctx.ServerError("CreateUser", err)
|
|
}
|
|
return
|
|
}
|
|
log.Trace("Account created by admin (%s): %s", ctx.Doer.Name, u.Name)
|
|
|
|
// Send email notification.
|
|
if form.SendNotify {
|
|
mailer.SendRegisterNotifyMail(u)
|
|
}
|
|
|
|
ctx.Flash.Success(ctx.Tr("admin.users.new_success", u.Name))
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users/" + strconv.FormatInt(u.ID, 10))
|
|
}
|
|
|
|
func prepareUserInfo(ctx *context.Context) *user_model.User {
|
|
u, err := user_model.GetUserByID(ctx, ctx.ParamsInt64(":userid"))
|
|
if err != nil {
|
|
if user_model.IsErrUserNotExist(err) {
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users")
|
|
} else {
|
|
ctx.ServerError("GetUserByID", err)
|
|
}
|
|
return nil
|
|
}
|
|
ctx.Data["User"] = u
|
|
|
|
if u.LoginSource > 0 {
|
|
ctx.Data["LoginSource"], err = auth.GetSourceByID(u.LoginSource)
|
|
if err != nil {
|
|
ctx.ServerError("auth.GetSourceByID", err)
|
|
return nil
|
|
}
|
|
} else {
|
|
ctx.Data["LoginSource"] = &auth.Source{}
|
|
}
|
|
|
|
sources, err := auth.Sources()
|
|
if err != nil {
|
|
ctx.ServerError("auth.Sources", err)
|
|
return nil
|
|
}
|
|
ctx.Data["Sources"] = sources
|
|
|
|
hasTOTP, err := auth.HasTwoFactorByUID(u.ID)
|
|
if err != nil {
|
|
ctx.ServerError("auth.HasTwoFactorByUID", err)
|
|
return nil
|
|
}
|
|
hasWebAuthn, err := auth.HasWebAuthnRegistrationsByUID(u.ID)
|
|
if err != nil {
|
|
ctx.ServerError("auth.HasWebAuthnRegistrationsByUID", err)
|
|
return nil
|
|
}
|
|
ctx.Data["TwoFactorEnabled"] = hasTOTP || hasWebAuthn
|
|
|
|
return u
|
|
}
|
|
|
|
// EditUser show editing user page
|
|
func EditUser(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("admin.users.edit_account")
|
|
ctx.Data["PageIsAdmin"] = true
|
|
ctx.Data["PageIsAdminUsers"] = true
|
|
ctx.Data["DisableRegularOrgCreation"] = setting.Admin.DisableRegularOrgCreation
|
|
ctx.Data["DisableMigrations"] = setting.Repository.DisableMigrations
|
|
ctx.Data["AllowedUserVisibilityModes"] = setting.Service.AllowedUserVisibilityModesSlice.ToVisibleTypeSlice()
|
|
|
|
prepareUserInfo(ctx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
ctx.HTML(http.StatusOK, tplUserEdit)
|
|
}
|
|
|
|
// EditUserPost response for editing user
|
|
func EditUserPost(ctx *context.Context) {
|
|
form := web.GetForm(ctx).(*forms.AdminEditUserForm)
|
|
ctx.Data["Title"] = ctx.Tr("admin.users.edit_account")
|
|
ctx.Data["PageIsAdmin"] = true
|
|
ctx.Data["PageIsAdminUsers"] = true
|
|
ctx.Data["DisableMigrations"] = setting.Repository.DisableMigrations
|
|
|
|
u := prepareUserInfo(ctx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
if ctx.HasError() {
|
|
ctx.HTML(http.StatusOK, tplUserEdit)
|
|
return
|
|
}
|
|
|
|
fields := strings.Split(form.LoginType, "-")
|
|
if len(fields) == 2 {
|
|
loginType, _ := strconv.ParseInt(fields[0], 10, 0)
|
|
authSource, _ := strconv.ParseInt(fields[1], 10, 64)
|
|
|
|
if u.LoginSource != authSource {
|
|
u.LoginSource = authSource
|
|
u.LoginType = auth.Type(loginType)
|
|
}
|
|
}
|
|
|
|
if len(form.Password) > 0 && (u.IsLocal() || u.IsOAuth2()) {
|
|
var err error
|
|
if len(form.Password) < setting.MinPasswordLength {
|
|
ctx.Data["Err_Password"] = true
|
|
ctx.RenderWithErr(ctx.Tr("auth.password_too_short", setting.MinPasswordLength), tplUserEdit, &form)
|
|
return
|
|
}
|
|
if !password.IsComplexEnough(form.Password) {
|
|
ctx.RenderWithErr(password.BuildComplexityError(ctx), tplUserEdit, &form)
|
|
return
|
|
}
|
|
pwned, err := password.IsPwned(ctx, form.Password)
|
|
if pwned {
|
|
ctx.Data["Err_Password"] = true
|
|
errMsg := ctx.Tr("auth.password_pwned")
|
|
if err != nil {
|
|
log.Error(err.Error())
|
|
errMsg = ctx.Tr("auth.password_pwned_err")
|
|
}
|
|
ctx.RenderWithErr(errMsg, tplUserNew, &form)
|
|
return
|
|
}
|
|
|
|
if err := user_model.ValidateEmail(form.Email); err != nil {
|
|
ctx.Data["Err_Email"] = true
|
|
ctx.RenderWithErr(ctx.Tr("form.email_error"), tplUserNew, &form)
|
|
return
|
|
}
|
|
|
|
if u.Salt, err = user_model.GetUserSalt(); err != nil {
|
|
ctx.ServerError("UpdateUser", err)
|
|
return
|
|
}
|
|
if err = u.SetPassword(form.Password); err != nil {
|
|
ctx.ServerError("SetPassword", err)
|
|
return
|
|
}
|
|
}
|
|
|
|
if len(form.UserName) != 0 && u.Name != form.UserName {
|
|
if err := user_setting.HandleUsernameChange(ctx, u, form.UserName); err != nil {
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users")
|
|
return
|
|
}
|
|
u.Name = form.UserName
|
|
u.LowerName = strings.ToLower(form.UserName)
|
|
}
|
|
|
|
if form.Reset2FA {
|
|
tf, err := auth.GetTwoFactorByUID(u.ID)
|
|
if err != nil && !auth.IsErrTwoFactorNotEnrolled(err) {
|
|
ctx.ServerError("auth.GetTwoFactorByUID", err)
|
|
return
|
|
} else if tf != nil {
|
|
if err := auth.DeleteTwoFactorByID(tf.ID, u.ID); err != nil {
|
|
ctx.ServerError("auth.DeleteTwoFactorByID", err)
|
|
return
|
|
}
|
|
}
|
|
|
|
wn, err := auth.GetWebAuthnCredentialsByUID(u.ID)
|
|
if err != nil {
|
|
ctx.ServerError("auth.GetTwoFactorByUID", err)
|
|
return
|
|
}
|
|
for _, cred := range wn {
|
|
if _, err := auth.DeleteCredential(cred.ID, u.ID); err != nil {
|
|
ctx.ServerError("auth.DeleteCredential", err)
|
|
return
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
u.LoginName = form.LoginName
|
|
u.FullName = form.FullName
|
|
emailChanged := !strings.EqualFold(u.Email, form.Email)
|
|
u.Email = form.Email
|
|
u.Website = form.Website
|
|
u.Location = form.Location
|
|
u.MaxRepoCreation = form.MaxRepoCreation
|
|
u.IsActive = form.Active
|
|
u.IsAdmin = form.Admin
|
|
u.IsRestricted = form.Restricted
|
|
u.AllowGitHook = form.AllowGitHook
|
|
u.AllowImportLocal = form.AllowImportLocal
|
|
u.AllowCreateOrganization = form.AllowCreateOrganization
|
|
|
|
u.Visibility = form.Visibility
|
|
|
|
// skip self Prohibit Login
|
|
if ctx.Doer.ID == u.ID {
|
|
u.ProhibitLogin = false
|
|
} else {
|
|
u.ProhibitLogin = form.ProhibitLogin
|
|
}
|
|
|
|
if err := user_model.UpdateUser(ctx, u, emailChanged); err != nil {
|
|
if user_model.IsErrEmailAlreadyUsed(err) {
|
|
ctx.Data["Err_Email"] = true
|
|
ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplUserEdit, &form)
|
|
} else if user_model.IsErrEmailCharIsNotSupported(err) ||
|
|
user_model.IsErrEmailInvalid(err) {
|
|
ctx.Data["Err_Email"] = true
|
|
ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tplUserEdit, &form)
|
|
} else {
|
|
ctx.ServerError("UpdateUser", err)
|
|
}
|
|
return
|
|
}
|
|
log.Trace("Account profile updated by admin (%s): %s", ctx.Doer.Name, u.Name)
|
|
|
|
ctx.Flash.Success(ctx.Tr("admin.users.update_profile_success"))
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users/" + url.PathEscape(ctx.Params(":userid")))
|
|
}
|
|
|
|
// DeleteUser response for deleting a user
|
|
func DeleteUser(ctx *context.Context) {
|
|
u, err := user_model.GetUserByID(ctx, ctx.ParamsInt64(":userid"))
|
|
if err != nil {
|
|
ctx.ServerError("GetUserByID", err)
|
|
return
|
|
}
|
|
|
|
// admin should not delete themself
|
|
if u.ID == ctx.Doer.ID {
|
|
ctx.Flash.Error(ctx.Tr("admin.users.cannot_delete_self"))
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users/" + url.PathEscape(ctx.Params(":userid")))
|
|
return
|
|
}
|
|
|
|
if err = user_service.DeleteUser(ctx, u, ctx.FormBool("purge")); err != nil {
|
|
switch {
|
|
case models.IsErrUserOwnRepos(err):
|
|
ctx.Flash.Error(ctx.Tr("admin.users.still_own_repo"))
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users/" + url.PathEscape(ctx.Params(":userid")))
|
|
case models.IsErrUserHasOrgs(err):
|
|
ctx.Flash.Error(ctx.Tr("admin.users.still_has_org"))
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users/" + url.PathEscape(ctx.Params(":userid")))
|
|
case models.IsErrUserOwnPackages(err):
|
|
ctx.Flash.Error(ctx.Tr("admin.users.still_own_packages"))
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users/" + ctx.Params(":userid"))
|
|
default:
|
|
ctx.ServerError("DeleteUser", err)
|
|
}
|
|
return
|
|
}
|
|
log.Trace("Account deleted by admin (%s): %s", ctx.Doer.Name, u.Name)
|
|
|
|
ctx.Flash.Success(ctx.Tr("admin.users.deletion_success"))
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users")
|
|
}
|
|
|
|
// AvatarPost response for change user's avatar request
|
|
func AvatarPost(ctx *context.Context) {
|
|
u := prepareUserInfo(ctx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
form := web.GetForm(ctx).(*forms.AvatarForm)
|
|
if err := user_setting.UpdateAvatarSetting(ctx, form, u); err != nil {
|
|
ctx.Flash.Error(err.Error())
|
|
} else {
|
|
ctx.Flash.Success(ctx.Tr("settings.update_user_avatar_success"))
|
|
}
|
|
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users/" + strconv.FormatInt(u.ID, 10))
|
|
}
|
|
|
|
// DeleteAvatar render delete avatar page
|
|
func DeleteAvatar(ctx *context.Context) {
|
|
u := prepareUserInfo(ctx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
if err := user_service.DeleteAvatar(u); err != nil {
|
|
ctx.Flash.Error(err.Error())
|
|
}
|
|
|
|
ctx.Redirect(setting.AppSubURL + "/admin/users/" + strconv.FormatInt(u.ID, 10))
|
|
}
|