zeripath
148a417774
Prevent off-by-one error on comments on newly appended lines ( #18029 ) ( #18035 )
...
* Prevent off-by-one error on comments on newly appended lines (#18029 )
Backport #18029
There was a bug in CutDiffAroundLine whereby if a file without a terminal new line
has a patch which appends lines to it and a comment is placed on one of those lines
the comment diff will be a line out of place.
This fixes CutDiffAroundLine to simply ignore the missing terminal newline - however,
we should really improve this rendering to add a marker to say that there was a
previously missing terminal newline.
Fix #17875
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Apply suggestions from code review
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2021-12-20 11:38:58 -05:00
..
2021-11-16 20:38:49 +00:00
2021-06-30 19:49:06 +02:00
2021-12-17 10:08:00 +08:00
2020-07-01 14:01:17 +01:00
2021-07-08 13:38:13 +02:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-05-10 03:27:03 +02:00
2021-10-25 17:46:56 +01:00
2021-11-16 20:38:49 +00:00
2021-06-26 13:47:56 +01:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-06-06 19:44:58 -04:00
2020-12-17 22:00:47 +08:00
2021-05-12 01:11:42 -04:00
2021-07-02 21:23:37 +02:00
2021-07-02 21:23:37 +02:00
2021-12-20 11:38:58 -05:00
2021-12-20 11:38:58 -05:00
2021-06-23 17:08:26 -04:00
2021-06-25 17:54:08 +01:00
2021-10-13 23:02:45 +03:00
2021-06-25 17:54:08 +01:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-06-25 17:54:08 +01:00
2021-06-26 13:28:55 +02:00
2021-09-10 17:46:06 +08:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-08-09 20:24:31 +01:00
2020-12-17 22:00:47 +08:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2019-03-27 17:33:00 +08:00
2020-11-08 12:21:54 -05:00
2021-06-14 19:20:43 +02:00
2021-06-23 17:12:38 -04:00
2020-10-21 11:42:08 -04:00
2021-11-16 20:38:49 +00:00
2021-12-17 10:08:00 +08:00
2019-07-23 19:50:39 +01:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-05-10 03:27:03 +02:00
2020-12-17 22:00:47 +08:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-02-03 20:06:13 +01:00
2021-02-03 20:06:13 +01:00
2021-11-16 20:38:49 +00:00
2021-12-17 10:08:00 +08:00
2021-06-30 19:49:06 +02:00
2021-07-08 13:38:13 +02:00
2021-11-16 20:38:49 +00:00
2020-08-11 21:05:34 +01:00
2021-02-16 16:39:45 +01:00
2019-10-16 14:42:42 +01:00
2019-03-27 17:33:00 +08:00
2019-08-05 21:39:39 +01:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2020-12-17 22:00:47 +08:00
2020-12-17 22:00:47 +08:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2019-11-13 07:01:19 +00:00
2020-12-17 22:00:47 +08:00
2020-01-20 12:07:30 +02:00
2021-07-08 13:38:13 +02:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-02-28 19:57:45 +00:00
2021-06-25 17:54:08 +01:00
2021-05-09 17:20:33 +02:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2020-12-17 22:00:47 +08:00
2021-06-23 17:08:26 -04:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2020-12-17 22:00:47 +08:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2020-12-17 22:00:47 +08:00
2020-09-07 20:08:10 -04:00
2021-11-16 20:38:49 +00:00
2020-12-22 21:44:25 +01:00
2021-05-12 01:11:42 -04:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2020-12-17 22:00:47 +08:00
2021-11-16 20:38:49 +00:00
2020-12-17 22:00:47 +08:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-05-10 03:27:03 +02:00
2021-11-16 20:38:49 +00:00
2021-11-16 20:38:49 +00:00
2021-07-21 03:37:00 +01:00
2020-05-14 18:55:43 -04:00
2021-07-08 13:38:13 +02:00