zeripath 888384a631

Correct the fallbacks for mailer configuration (#21945) (#21953) ...

Backport #21945

Unfortunately the fallback configuration code for [mailer] that were
added in #18982 are incorrect. When you read a value from an ini section
that key is added. This leads to a failure of the fallback mechanism.
Further there is also a spelling mistake in the startTLS configuration.

This PR restructures the mailer code to first map the deprecated
settings on to the new ones - and then use ini.MapTo to map those on to
the struct with additional validation as necessary.

Ref #21744

Signed-off-by: Andrew Thornton <art27@cantab.net>

2022-11-27 19:45:59 +00:00

..

activitypub

Fix dashboard ignored system setting cache (#21621) (#21759)

2022-11-10 19:41:44 +08:00

analyze

Simplify IsVendor (#19626)

2022-05-06 10:12:30 +01:00

auth

Remove legacy +build: constraint (#19582)

2022-05-02 23:22:45 +08:00

avatar

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

base

Add generic set type (#21408)

2022-10-12 13:18:26 +08:00

cache

Fix dashboard ignored system setting cache (#21621) (#21759)

2022-11-10 19:41:44 +08:00

charset

Move go-licenses to generate and separate generate into a frontend and backend component (#21061)

2022-09-05 14:04:18 +08:00

container

Add generic set type (#21408)

2022-10-12 13:18:26 +08:00

context

Add support for HEAD requests in Maven registry (#21834) (#21929)

2022-11-25 13:46:28 +02:00

convert

Record OAuth client type at registration (#21316)

2022-10-24 15:59:24 +08:00

csv

Go 1.19 format (#20758)

2022-08-30 21:15:45 -05:00

doctor

Prevent dangling user redirects (#21856) (#21858)

2022-11-18 22:25:00 +08:00

emoji

Go 1.19 format (#20758)

2022-08-30 21:15:45 -05:00

eventsource

Move some files into models' sub packages (#20262)

2022-08-25 10:31:57 +08:00

generate

Use base32 for 2FA scratch token (#18384)

2022-01-26 12:10:10 +08:00

git

Prevent panic in doctor command when running default checks (#21791) (#21807)

2022-11-14 10:58:32 +08:00

gitgraph

Refactor git command arguments and make all arguments to be safe to be used (#21535)

2022-10-23 22:44:45 +08:00

graceful

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

hcaptcha

hCaptcha Support (#12594)

2020-10-02 23:37:53 -04:00

highlight

Upgrade chroma to v2.3.0 (#21259)

2022-09-26 13:50:03 +08:00

hostmatcher

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

httpcache

Add Cache-Control header to html and api responses, add no-transform (#20432)

2022-07-23 14:38:03 +08:00

httplib

refactor httplib (#18338)

2022-01-19 19:31:39 -05:00

indexer

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

issue/template

Support comma-delimited string as labels in issue template (#21831) (#21873)

2022-11-20 10:44:20 +00:00

json

Refactor legacy unknwon/com package, improve golangci lint (#19284)

2022-04-01 16:47:50 +08:00

lfs

Removed some vestigial code related to Range bounds checks (#20312)

2022-07-28 11:04:36 +08:00

log

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

markup

Support comma-delimited string as labels in issue template (#21831) (#21873)

2022-11-20 10:44:20 +00:00

mcaptcha

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

metrics

Move some files into models' sub packages (#20262)

2022-08-25 10:31:57 +08:00

migration

Add more checks in migration code (#21011)

2022-09-04 13:47:56 +03:00

mirror

Implement sync push mirror on commit (#19411)

2022-07-08 20:45:12 +01:00

nosql

fix broken insecureskipverify handling in rediss connection uris (#20967)

2022-08-29 16:38:49 +02:00

notification

Decouple HookTask from Repository (#17940)

2022-10-21 18:21:56 +02:00

options

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

packages

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

paginator

Remove unnecessary misspell ignore pattern (#21475)

2022-10-18 12:52:25 -04:00

password

Fixed assert statements. (#16089)

2021-06-07 07:27:09 +02:00

pprof

Go 1.19 format (#20758)

2022-08-30 21:15:45 -05:00

private

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

process

Add more linters to improve code readability (#19989)

2022-06-20 12:02:49 +02:00

proxy

Return nil proxy function if proxy not enabled (#16742)

2021-08-19 16:41:20 -04:00

proxyprotocol

Support Proxy protocol (#12527)

2022-08-21 19:20:43 +01:00

public

Add generic set type (#21408)

2022-10-12 13:18:26 +08:00

queue

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

recaptcha

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

references

Remove unnecessary misspell ignore pattern (#21475)

2022-10-18 12:52:25 -04:00

regexplru

Custom regexp external issues (#17624)

2022-06-10 13:39:53 +08:00

repository

Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551)

2022-10-24 20:29:17 +01:00

secret

Use CryptoRandomBytes instead of CryptoRandomString (#18439)

2022-02-04 18:03:15 +01:00

session

format with gofumpt (#18184)

2022-01-20 18:46:10 +01:00

setting

Correct the fallbacks for mailer configuration (#21945) (#21953)

2022-11-27 19:45:59 +00:00

sitemap

Add sitemap support (#18407)

2022-06-25 19:06:01 +02:00

ssh

Support Proxy protocol (#12527)

2022-08-21 19:20:43 +01:00

storage

Save files in local storage as umask (#21198)

2022-09-24 21:04:14 +08:00

structs

Support comma-delimited string as labels in issue template (#21831) (#21873)

2022-11-20 10:44:20 +00:00

svg

Remove legacy +build: constraint (#19582)

2022-05-02 23:22:45 +08:00

sync

Add generic set type (#21408)

2022-10-12 13:18:26 +08:00

system

Fix dashboard ignored system setting cache (#21621) (#21759)

2022-11-10 19:41:44 +08:00

templates

Fix vertical align of committer avatar rendered by email address (#21884) (#21918)

2022-11-24 10:52:20 +08:00

test

Refactor AssertExistsAndLoadBean to use generics (#20797)

2022-08-16 10:22:25 +08:00

timeutil

Fix Timestamp.IsZero (#21593) (#21603)

2022-10-27 16:47:06 +08:00

translation

Make every not exist error unwrappable to a fs.ErrNotExist (#20891)

2022-10-18 07:50:37 +02:00

typesniffer

Rework raw file http header logic (#20484)

2022-07-29 17:26:55 +02:00

updatechecker

Add system setting table with cache and also add cache supports for user setting (#18058)

2022-10-17 07:29:26 +08:00

upload

Simplify parameter types (#18006)

2021-12-20 04:41:31 +00:00

uri

Prevent NPE if gitea uploader fails to open url (#18080)

2021-12-23 16:27:33 +00:00

user

…

util

Make every not exist error unwrappable to a fs.ErrNotExist (#20891)

2022-10-18 07:50:37 +02:00

validation

Add more checks in migration code (#21011)

2022-09-04 13:47:56 +03:00

watcher

Share HTML template renderers and create a watcher framework (#20218)

2022-08-28 10:43:25 +01:00

web

refactor webhook *NewPost (#20729)

2022-08-11 17:48:23 +02:00