gitea/services
wxiaoguang dd8bc1d61d
Refactor issue template parsing and fix API endpoint (#29069) (#29140)
Backport #29069

The old code `GetTemplatesFromDefaultBranch(...) ([]*api.IssueTemplate,
map[string]error)` doesn't really follow Golang's habits, then the
second returned value might be misused. For example, the API function
`GetIssueTemplates` incorrectly checked the second returned value and
always responds 500 error.

This PR refactors GetTemplatesFromDefaultBranch to
ParseTemplatesFromDefaultBranch and clarifies its behavior, and fixes
the API endpoint bug, and adds some tests.

And by the way, add proper prefix `X-` for the header generated in
`checkDeprecatedAuthMethods`, because non-standard HTTP headers should
have `X-` prefix, and it is also consistent with the new code in
`GetIssueTemplates`
2024-02-14 01:32:31 +00:00
..
actions Fix an actions schedule bug (#28942) (#28999) 2024-01-31 15:52:31 +00:00
agit
asymkey
attachment
auth Deprecate query string auth tokens (#28390) (#28430) 2023-12-12 13:45:00 +08:00
automerge
context
convert Fix an actions schedule bug (#28942) (#28999) 2024-01-31 15:52:31 +00:00
cron Recover from panic in cron task (#28409) (#28425) 2023-12-12 03:28:56 +00:00
externalaccount
feed
forms Fix required error for token name (#28267) (#28284) 2023-11-29 23:00:32 +08:00
gitdiff Add option to disable ambiguous unicode characters detection (#28454) (#28499) 2023-12-18 12:20:37 +08:00
indexer Fix missing issue search index update when changing status (#28325) (#28330) 2023-12-03 11:43:17 +00:00
issue Refactor issue template parsing and fix API endpoint (#29069) (#29140) 2024-02-14 01:32:31 +00:00
lfs
mailer Rework markup link rendering (#26745) (#28803) 2024-01-16 02:13:29 +00:00
markup
migrations Only migrate the first 255 chars of a Github issue title (#28902) (#28912) 2024-01-24 19:56:54 +08:00
mirror
notify
org Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
packages Fix reverting a merge commit failing (#28794) (#28825) 2024-01-21 14:18:37 +00:00
pull Concatenate error in checkIfPRContentChanged (#28731) (#28737) 2024-01-09 14:06:12 +00:00
release Avoid sending update/delete release notice when it is draft (#29008) (#29025) 2024-02-02 09:37:37 +00:00
repository Fix an actions schedule bug (#28942) (#28999) 2024-01-31 15:52:31 +00:00
secrets
task Fix incorrect ctx usage in defer function (#27740) (#27741) 2023-10-22 14:36:49 +00:00
uinotification
user Forbid removing the last admin user (#28337) (#28793) 2024-01-16 01:51:46 +00:00
webhook Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
wiki Fix an actions schedule bug (#28942) (#28999) 2024-01-31 15:52:31 +00:00