mirror of
https://github.com/go-gitea/gitea
synced 2024-11-18 05:29:27 +01:00
9a83aa28a3
When users rename an existing branch protection rule, a new rule with the new name will be created and the old rule will still exist. ![image](https://user-images.githubusercontent.com/15528715/219276442-d3c001ad-e693-44ec-9ad2-b33f2666b49b.png) --- ![image](https://user-images.githubusercontent.com/15528715/219276478-547c3b93-b3f1-4292-a1ef-c1b7747fe1bb.png) The reason is that the `SettingsProtectedBranchPost` function only get branch protection rule by name before updating or creating a rule. When the rule name changes, the function cannot find the existing rule so it will create a new rule rather than update the existing rule. To fix the bug, the function should get rule by id first. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> |
||
---|---|---|
.. | ||
admin.go | ||
auth_form.go | ||
org.go | ||
package_form.go | ||
repo_branch_form.go | ||
repo_form_test.go | ||
repo_form.go | ||
repo_tag_form.go | ||
runner.go | ||
user_form_auth_openid.go | ||
user_form_hidden_comments.go | ||
user_form_test.go | ||
user_form.go |