mirror of
https://github.com/go-gitea/gitea
synced 2024-12-23 04:57:51 +01:00
9f73cae635
* Fix wrong type on hooktask to convert typ from char(16) to varchar(16) * Fix bugs * Improve code * Use different trim function for MSSQL * Fix bug * Removed wrong changed line * Removed wrong changed line * Fix nullable * Fix lint * Ignore sqlite on migration * Fix mssql modify column failure * Move modifyColumn to migrations.go so that other migrate function could use it
67 lines
1.5 KiB
Go
67 lines
1.5 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package migrations
|
|
|
|
import (
|
|
"xorm.io/xorm"
|
|
"xorm.io/xorm/schemas"
|
|
)
|
|
|
|
func convertHookTaskTypeToVarcharAndTrim(x *xorm.Engine) error {
|
|
dbType := x.Dialect().URI().DBType
|
|
if dbType == schemas.SQLITE { // For SQLITE, varchar or char will always be represented as TEXT
|
|
return nil
|
|
}
|
|
|
|
type HookTask struct {
|
|
Typ string `xorm:"VARCHAR(16) index"`
|
|
}
|
|
|
|
if err := modifyColumn(x, "hook_task", &schemas.Column{
|
|
Name: "typ",
|
|
SQLType: schemas.SQLType{
|
|
Name: "VARCHAR",
|
|
},
|
|
Length: 16,
|
|
Nullable: true, // To keep compatible as nullable
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
|
|
var hookTaskTrimSQL string
|
|
if dbType == schemas.MSSQL {
|
|
hookTaskTrimSQL = "UPDATE hook_task SET typ = RTRIM(LTRIM(typ))"
|
|
} else {
|
|
hookTaskTrimSQL = "UPDATE hook_task SET typ = TRIM(typ)"
|
|
}
|
|
if _, err := x.Exec(hookTaskTrimSQL); err != nil {
|
|
return err
|
|
}
|
|
|
|
type Webhook struct {
|
|
Type string `xorm:"VARCHAR(16) index"`
|
|
}
|
|
|
|
if err := modifyColumn(x, "webhook", &schemas.Column{
|
|
Name: "type",
|
|
SQLType: schemas.SQLType{
|
|
Name: "VARCHAR",
|
|
},
|
|
Length: 16,
|
|
Nullable: true, // To keep compatible as nullable
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
|
|
var webhookTrimSQL string
|
|
if dbType == schemas.MSSQL {
|
|
webhookTrimSQL = "UPDATE webhook SET type = RTRIM(LTRIM(type))"
|
|
} else {
|
|
webhookTrimSQL = "UPDATE webhook SET type = TRIM(type)"
|
|
}
|
|
_, err := x.Exec(webhookTrimSQL)
|
|
return err
|
|
}
|