mirror of
https://github.com/go-gitea/gitea
synced 2024-12-25 06:05:56 +01:00
0690cb076b
Fix #28121 I did some tests and found that the `missing signature key` error is caused by an incorrect `Content-Type` header. Gitea correctly sets the `Content-Type` header when serving files.348d1d0f32/routers/api/packages/container/container.go (L712-L717)However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may be set to an incorrect value by the storage service. To fix this issue, we can use query parameters to override response header values. https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html <img width="600px" src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555" /> In this PR, I introduced a new parameter to the `URL` method to support additional parameters. ``` URL(path, name string, reqParams url.Values) (*url.URL, error) ``` --- Most S3-like services support specifying the content type when storing objects. However, Gitea always use `application/octet-stream`. Therefore, I believe we also need to improve the `Save` method to support storing objects with the correct content type.b7fb20e73e/modules/storage/minio.go (L214-L221)
51 lines
1.0 KiB
Go
51 lines
1.0 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package storage
|
|
|
|
import (
|
|
"bytes"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_discardStorage(t *testing.T) {
|
|
tests := []discardStorage{
|
|
uninitializedStorage,
|
|
discardStorage("empty"),
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(string(tt), func(t *testing.T) {
|
|
{
|
|
got, err := tt.Open("path")
|
|
assert.Nil(t, got)
|
|
assert.Error(t, err, string(tt))
|
|
}
|
|
{
|
|
got, err := tt.Save("path", bytes.NewReader([]byte{0}), 1)
|
|
assert.Equal(t, int64(0), got)
|
|
assert.Error(t, err, string(tt))
|
|
}
|
|
{
|
|
got, err := tt.Stat("path")
|
|
assert.Nil(t, got)
|
|
assert.Error(t, err, string(tt))
|
|
}
|
|
{
|
|
err := tt.Delete("path")
|
|
assert.Error(t, err, string(tt))
|
|
}
|
|
{
|
|
got, err := tt.URL("path", "name", nil)
|
|
assert.Nil(t, got)
|
|
assert.Errorf(t, err, string(tt))
|
|
}
|
|
{
|
|
err := tt.IterateObjects("", func(_ string, _ Object) error { return nil })
|
|
assert.Error(t, err, string(tt))
|
|
}
|
|
})
|
|
}
|
|
}
|