mirror of
https://github.com/go-gitea/gitea
synced 2024-12-22 16:37:52 +01:00
716fcfcf72
A lot of our code is repeatedly testing if individual errors are specific types of Not Exist errors. This is repetitative and unnecesary. `Unwrap() error` provides a common way of labelling an error as a NotExist error and we can/should use this. This PR has chosen to use the common `io/fs` errors e.g. `fs.ErrNotExist` for our errors. This is in some ways not completely correct as these are not filesystem errors but it seems like a reasonable thing to do and would allow us to simplify a lot of our code to `errors.Is(err, fs.ErrNotExist)` instead of `package.IsErr...NotExist(err)` I am open to suggestions to use a different base error - perhaps `models/db.ErrNotExist` if that would be felt to be better. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de>
88 lines
2.4 KiB
Go
88 lines
2.4 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package repo
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/modules/util"
|
|
)
|
|
|
|
// ErrRedirectNotExist represents a "RedirectNotExist" kind of error.
|
|
type ErrRedirectNotExist struct {
|
|
OwnerID int64
|
|
RepoName string
|
|
}
|
|
|
|
// IsErrRedirectNotExist check if an error is an ErrRepoRedirectNotExist.
|
|
func IsErrRedirectNotExist(err error) bool {
|
|
_, ok := err.(ErrRedirectNotExist)
|
|
return ok
|
|
}
|
|
|
|
func (err ErrRedirectNotExist) Error() string {
|
|
return fmt.Sprintf("repository redirect does not exist [uid: %d, name: %s]", err.OwnerID, err.RepoName)
|
|
}
|
|
|
|
func (err ErrRedirectNotExist) Unwrap() error {
|
|
return util.ErrNotExist
|
|
}
|
|
|
|
// Redirect represents that a repo name should be redirected to another
|
|
type Redirect struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
OwnerID int64 `xorm:"UNIQUE(s)"`
|
|
LowerName string `xorm:"UNIQUE(s) INDEX NOT NULL"`
|
|
RedirectRepoID int64 // repoID to redirect to
|
|
}
|
|
|
|
// TableName represents real table name in database
|
|
func (Redirect) TableName() string {
|
|
return "repo_redirect"
|
|
}
|
|
|
|
func init() {
|
|
db.RegisterModel(new(Redirect))
|
|
}
|
|
|
|
// LookupRedirect look up if a repository has a redirect name
|
|
func LookupRedirect(ownerID int64, repoName string) (int64, error) {
|
|
repoName = strings.ToLower(repoName)
|
|
redirect := &Redirect{OwnerID: ownerID, LowerName: repoName}
|
|
if has, err := db.GetEngine(db.DefaultContext).Get(redirect); err != nil {
|
|
return 0, err
|
|
} else if !has {
|
|
return 0, ErrRedirectNotExist{OwnerID: ownerID, RepoName: repoName}
|
|
}
|
|
return redirect.RedirectRepoID, nil
|
|
}
|
|
|
|
// NewRedirect create a new repo redirect
|
|
func NewRedirect(ctx context.Context, ownerID, repoID int64, oldRepoName, newRepoName string) error {
|
|
oldRepoName = strings.ToLower(oldRepoName)
|
|
newRepoName = strings.ToLower(newRepoName)
|
|
|
|
if err := DeleteRedirect(ctx, ownerID, newRepoName); err != nil {
|
|
return err
|
|
}
|
|
|
|
return db.Insert(ctx, &Redirect{
|
|
OwnerID: ownerID,
|
|
LowerName: oldRepoName,
|
|
RedirectRepoID: repoID,
|
|
})
|
|
}
|
|
|
|
// DeleteRedirect delete any redirect from the specified repo name to
|
|
// anything else
|
|
func DeleteRedirect(ctx context.Context, ownerID int64, repoName string) error {
|
|
repoName = strings.ToLower(repoName)
|
|
_, err := db.GetEngine(ctx).Delete(&Redirect{OwnerID: ownerID, LowerName: repoName})
|
|
return err
|
|
}
|