mirror of
https://github.com/go-gitea/gitea
synced 2024-08-17 21:00:48 +02:00
`hex.EncodeToString` has better performance than `fmt.Sprintf("%x", []byte)`, we should use it as much as possible. I'm not an extreme fan of performance, so I think there are some exceptions: - `fmt.Sprintf("%x", func(...)[N]byte())` - We can't slice the function return value directly, and it's not worth adding lines. ```diff func A()[20]byte { ... } - a := fmt.Sprintf("%x", A()) - a := hex.EncodeToString(A()[:]) // invalid + tmp := A() + a := hex.EncodeToString(tmp[:]) ``` - `fmt.Sprintf("%X", []byte)` - `strings.ToUpper(hex.EncodeToString(bytes))` has even worse performance. |
||
---|---|---|
.. | ||
base | ||
fixtures | ||
v1_6 | ||
v1_7 | ||
v1_8 | ||
v1_9 | ||
v1_10 | ||
v1_11 | ||
v1_12 | ||
v1_13 | ||
v1_14 | ||
v1_15 | ||
v1_16 | ||
v1_17 | ||
v1_18 | ||
v1_19 | ||
migrations.go |