1
1
mirror of https://github.com/ytdl-org/youtube-dl synced 2024-12-24 02:15:55 +01:00

[README.md] Add more guide lines for regular expressions

This commit is contained in:
Sergey M 2019-01-01 23:13:39 +07:00 committed by GitHub
parent 0e713dbb11
commit 696f4e4114
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1133,11 +1133,33 @@ title = meta.get('title') or self._og_search_title(webpage)
This code will try to extract from `meta` first and if it fails it will try extracting `og:title` from a `webpage`.
### Make regular expressions flexible
### Regular expressions
When using regular expressions try to write them fuzzy and flexible.
#### Don't capture groups you don't use
Capturing group must be an indication that it's used somewhere in the code. Any group that is not used must be non capturing.
##### Example
Don't capture id attribute name here since you can't use it for anything anyway.
Correct:
```python
r'(?:id|ID)=(?P<id>\d+)'
```
Incorrect:
```python
r'(id|ID)=(?P<id>\d+)'
```
#### Make regular expressions relaxed and flexible
When using regular expressions try to write them fuzzy, relaxed and flexible, skipping insignificant parts that are more likely to change, allowing both single and double quotes for quoted values and so on.
#### Example
##### Example
Say you need to extract `title` from the following HTML code: