From 09f1580e2d29e256d753a8112f093d4e0a54478e Mon Sep 17 00:00:00 2001 From: pukkandan Date: Fri, 21 May 2021 20:04:30 +0530 Subject: [PATCH] [youtube] `/live` URLs should raise error if channel is not live Fixes: https://github.com/ytdl-org/youtube-dl/issues/29090 --- README.md | 2 +- yt_dlp/extractor/youtube.py | 44 ++++++++++++++++++++++--------------- 2 files changed, 27 insertions(+), 19 deletions(-) diff --git a/README.md b/README.md index 2a719f51c..b1ad22416 100644 --- a/README.md +++ b/README.md @@ -128,7 +128,7 @@ ### Differences in default behavior * `playlist_index` behaves differently when used with options like `--playlist-reverse` and `--playlist-items`. See [#302](https://github.com/yt-dlp/yt-dlp/issues/302) for details. You can use `--compat-options playlist-index` if you want to keep the earlier behavior * The output of `-F` is listed in a new format. Use `--compat-options list-formats` to revert this * Youtube live chat (if available) is considered as a subtitle. Use `--sub-langs all,-live_chat` to download all subtitles except live chat. You can also use `--compat-options no-live-chat` to prevent live chat from downloading -* Youtube channel URLs are automatically redirected to `/video`. Either append a `/featured` to the URL or use `--compat-options no-youtube-channel-redirect` to download only the videos in the home page +* Youtube channel URLs are automatically redirected to `/video`. Append a `/featured` to the URL to download only the videos in the home page. If the channel does not have a videos tab, we try to download the equivalent `UU` playlist instead. Also, `/live` URLs raise an error if there are no live videos instead of silently downloading the entire channel. You may use `--compat-options no-youtube-channel-redirect` to revert all these redirections * Unavailable videos are also listed for youtube playlists. Use `--compat-options no-youtube-unavailable-videos` to remove this For ease of use, a few more compat options are available: diff --git a/yt_dlp/extractor/youtube.py b/yt_dlp/extractor/youtube.py index 48b489523..e5764210b 100644 --- a/yt_dlp/extractor/youtube.py +++ b/yt_dlp/extractor/youtube.py @@ -2854,6 +2854,10 @@ class YoutubeTabIE(YoutubeBaseInfoExtractor): }, { 'url': 'https://www.youtube.com/c/CommanderVideoHq/live', 'only_matching': True, + }, { + 'note': 'A channel that is not live. Should raise error', + 'url': 'https://www.youtube.com/user/numberphile/live', + 'only_matching': True, }, { 'url': 'https://www.youtube.com/feed/trending', 'only_matching': True, @@ -3710,23 +3714,26 @@ def get_mobj(url): if tabs: selected_tab = self._extract_selected_tab(tabs) tab_name = selected_tab.get('title', '') - if (mobj['tab'] == '/videos' and tab_name.lower() != mobj['tab'][1:] - and 'no-youtube-channel-redirect' not in compat_opts): - if not mobj['not_channel'] and item_id[:2] == 'UC': - # Topic channels don't have /videos. Use the equivalent playlist instead - self.report_warning('The URL does not have a %s tab. Trying to redirect to playlist UU%s instead' % (mobj['tab'][1:], item_id[2:])) - pl_id = 'UU%s' % item_id[2:] - pl_url = 'https://www.youtube.com/playlist?list=%s%s' % (pl_id, mobj['post']) - try: - pl_webpage, pl_data = self._extract_webpage(pl_url, pl_id) - for alert_type, alert_message in self._extract_alerts(pl_data): - if alert_type == 'error': - raise ExtractorError('Youtube said: %s' % alert_message) - item_id, url, webpage, data = pl_id, pl_url, pl_webpage, pl_data - except ExtractorError: - self.report_warning('The playlist gave error. Falling back to channel URL') - else: - self.report_warning('The URL does not have a %s tab. %s is being downloaded instead' % (mobj['tab'][1:], tab_name)) + if 'no-youtube-channel-redirect' not in compat_opts: + if mobj['tab'] == '/live': + # Live tab should have redirected to the video + raise ExtractorError('The channel is not currently live', expected=True) + if mobj['tab'] == '/videos' and tab_name.lower() != mobj['tab'][1:]: + if not mobj['not_channel'] and item_id[:2] == 'UC': + # Topic channels don't have /videos. Use the equivalent playlist instead + self.report_warning('The URL does not have a %s tab. Trying to redirect to playlist UU%s instead' % (mobj['tab'][1:], item_id[2:])) + pl_id = 'UU%s' % item_id[2:] + pl_url = 'https://www.youtube.com/playlist?list=%s%s' % (pl_id, mobj['post']) + try: + pl_webpage, pl_data = self._extract_webpage(pl_url, pl_id) + for alert_type, alert_message in self._extract_alerts(pl_data): + if alert_type == 'error': + raise ExtractorError('Youtube said: %s' % alert_message) + item_id, url, webpage, data = pl_id, pl_url, pl_webpage, pl_data + except ExtractorError: + self.report_warning('The playlist gave error. Falling back to channel URL') + else: + self.report_warning('The URL does not have a %s tab. %s is being downloaded instead' % (mobj['tab'][1:], tab_name)) self.write_debug('Final URL: %s' % url) @@ -3749,7 +3756,8 @@ def get_mobj(url): data, lambda x: x['currentVideoEndpoint']['watchEndpoint']['videoId'], compat_str) or video_id if video_id: - self.report_warning('Unable to recognize playlist. Downloading just video %s' % video_id) + if mobj['tab'] != '/live': # live tab is expected to redirect to video + self.report_warning('Unable to recognize playlist. Downloading just video %s' % video_id) return self.url_result(video_id, ie=YoutubeIE.ie_key(), video_id=video_id) raise ExtractorError('Unable to recognize tab page')